mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
becc3ec372
This flag is partially used in tests where it was not necessary and it is always possible to replace this flag with `common.allowGlobals`. This makes sure all globals are truly tested for. PR-URL: https://github.com/nodejs/node/pull/20717 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
57 lines
1.5 KiB
JavaScript
57 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const deprecatedModules = [
|
|
'node-inspect/lib/_inspect',
|
|
'node-inspect/lib/internal/inspect_client',
|
|
'node-inspect/lib/internal/inspect_repl',
|
|
'v8/tools/SourceMap',
|
|
'v8/tools/codemap',
|
|
'v8/tools/consarray',
|
|
'v8/tools/csvparser',
|
|
'v8/tools/logreader',
|
|
'v8/tools/profile',
|
|
'v8/tools/profile_view',
|
|
'v8/tools/splaytree',
|
|
'v8/tools/tickprocessor',
|
|
'v8/tools/tickprocessor-driver'
|
|
];
|
|
|
|
// Newly added deps that do not have a deprecation wrapper around it would
|
|
// throw an error, but no warning would be emitted.
|
|
const deps = [
|
|
'acorn/dist/acorn',
|
|
'acorn/dist/walk'
|
|
];
|
|
|
|
common.expectWarning('DeprecationWarning', deprecatedModules.map((m) => {
|
|
return [`Requiring Node.js-bundled '${m}' module is deprecated. ` +
|
|
'Please install the necessary module locally.', 'DEP0084'];
|
|
}));
|
|
|
|
for (const m of deprecatedModules) {
|
|
try {
|
|
require(m);
|
|
} catch (err) {}
|
|
}
|
|
|
|
// Instead of checking require, check that resolve isn't pointing toward a
|
|
// built-in module, as user might already have node installed with acorn in
|
|
// require.resolve range.
|
|
// Ref: https://github.com/nodejs/node/issues/17148
|
|
for (const m of deps) {
|
|
let path;
|
|
try {
|
|
path = require.resolve(m);
|
|
} catch (err) {
|
|
assert.ok(err.toString().startsWith('Error: Cannot find module '));
|
|
continue;
|
|
}
|
|
assert.notStrictEqual(path, m);
|
|
}
|
|
|
|
// The V8 modules add the WebInspector to the globals.
|
|
common.allowGlobals(global.WebInspector);
|