mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
44 lines
1.3 KiB
JavaScript
44 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.disableCrashOnUnhandledRejection();
|
|
|
|
const expectedDeprecationWarning = ['Unhandled promise rejections are ' +
|
|
'deprecated. In the future, promise ' +
|
|
'rejections that are not handled will ' +
|
|
'terminate the Node.js process with a ' +
|
|
'non-zero exit code.', 'DEP0018'];
|
|
const expectedPromiseWarning = ['Unhandled promise rejection. ' +
|
|
'This error originated either by throwing ' +
|
|
'inside of an async function without a catch ' +
|
|
'block, or by rejecting a promise which was ' +
|
|
'not handled with .catch(). (rejection id: 1)', common.noWarnCode];
|
|
|
|
function throwErr() {
|
|
throw new Error('Error from proxy');
|
|
}
|
|
|
|
const thorny = new Proxy({}, {
|
|
getPrototypeOf: throwErr,
|
|
setPrototypeOf: throwErr,
|
|
isExtensible: throwErr,
|
|
preventExtensions: throwErr,
|
|
getOwnPropertyDescriptor: throwErr,
|
|
defineProperty: throwErr,
|
|
has: throwErr,
|
|
get: throwErr,
|
|
set: throwErr,
|
|
deleteProperty: throwErr,
|
|
ownKeys: throwErr,
|
|
apply: throwErr,
|
|
construct: throwErr
|
|
});
|
|
|
|
common.expectWarning({
|
|
DeprecationWarning: expectedDeprecationWarning,
|
|
UnhandledPromiseRejectionWarning: expectedPromiseWarning,
|
|
});
|
|
|
|
// ensure this doesn't crash
|
|
Promise.reject(thorny);
|