mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
c6b6c92185
This makes a effort to make sure all of these errors will actually also show the received input. On top of that it refactors a few tests for better maintainability. It will also change the returned type to always be a simple typeof instead of special handling null. PR-URL: https://github.com/nodejs/node/pull/19445 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
42 lines
1.2 KiB
JavaScript
42 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
|
|
[false, 1, [], {}, null, undefined].forEach((input) => {
|
|
const type = `of type string, Buffer, or URL. Received type ${typeof input}`;
|
|
assert.throws(
|
|
() => fs.rename(input, 'does-not-exist', common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: `The "oldPath" argument must be one ${type}`
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.rename('does-not-exist', input, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: `The "newPath" argument must be one ${type}`
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.renameSync(input, 'does-not-exist'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: `The "oldPath" argument must be one ${type}`
|
|
}
|
|
);
|
|
assert.throws(
|
|
() => fs.renameSync('does-not-exist', input),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError [ERR_INVALID_ARG_TYPE]',
|
|
message: `The "newPath" argument must be one ${type}`
|
|
}
|
|
);
|
|
});
|