mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
1fd69872e6
We've added a number of tests that hook into ESLint which can error when running the test suite with the distributed tarball. This PR adds a new test helper `common.skipIfEslintMissing` and will skip remaining tests in a file when `ESLint` is not available at `tools/node_modules/eslint` PR-URL: https://github.com/nodejs/node/pull/18807 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
30 lines
811 B
JavaScript
30 lines
811 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
common.skipIfEslintMissing();
|
|
|
|
const RuleTester = require('../../tools/node_modules/eslint').RuleTester;
|
|
const rule = require('../../tools/eslint-rules/prefer-common-expectserror');
|
|
|
|
const message = 'Please use common.expectsError(fn, err) instead of ' +
|
|
'assert.throws(fn, common.expectsError(err)).';
|
|
|
|
new RuleTester().run('prefer-common-expectserror', rule, {
|
|
valid: [
|
|
'assert.throws(fn, /[a-z]/)',
|
|
'assert.throws(function () {}, function() {})',
|
|
'common.expectsError(function() {}, err)'
|
|
],
|
|
invalid: [
|
|
{
|
|
code: 'assert.throws(function() {}, common.expectsError(err))',
|
|
errors: [{ message }]
|
|
},
|
|
{
|
|
code: 'assert.throws(fn, common.expectsError(err))',
|
|
errors: [{ message }]
|
|
}
|
|
]
|
|
});
|