mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 19:17:56 +00:00

We can `dns.lookup` a falsy `hostname` like `dns.lookup(false)` for the reason of backwards compatibility long before(see #13119 for detail). This behavior is undocumented and seems useless in real world apps. We could also make invalid `hostname` throw in the future and the change might be semver-major. Fixes: https://github.com/nodejs/node/issues/13119 PR-URL: https://github.com/nodejs/node/pull/23173 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
164 lines
3.8 KiB
JavaScript
164 lines
3.8 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const cares = internalBinding('cares_wrap');
|
|
const dns = require('dns');
|
|
const dnsPromises = dns.promises;
|
|
|
|
// Stub `getaddrinfo` to *always* error.
|
|
cares.getaddrinfo = () => internalBinding('uv').UV_ENOENT;
|
|
|
|
{
|
|
const err = {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: /^The "hostname" argument must be of type string\. Received type number/
|
|
};
|
|
|
|
common.expectsError(() => dns.lookup(1, {}), err);
|
|
common.expectsError(() => dnsPromises.lookup(1, {}), err);
|
|
}
|
|
|
|
common.expectWarning({
|
|
// For 'internal/test/binding' module.
|
|
'internal/test/binding': [
|
|
'These APIs are exposed only for testing and are not ' +
|
|
'tracked by any versioning system or deprecation process.'
|
|
],
|
|
// For dns.promises.
|
|
'ExperimentalWarning': [
|
|
'The dns.promises API is experimental'
|
|
],
|
|
// For calling `dns.lookup` with falsy `hostname`.
|
|
'DeprecationWarning': [
|
|
'The provided hostname "false" is not a valid ' +
|
|
'hostname, and is supported in the dns module solely for compatibility.',
|
|
'DEP0118',
|
|
],
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, 'cb');
|
|
}, {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
common.expectsError(() => {
|
|
dns.lookup(false, 'options', 'cb');
|
|
}, {
|
|
code: 'ERR_INVALID_CALLBACK',
|
|
type: TypeError
|
|
});
|
|
|
|
{
|
|
const err = {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: 'The value "100" is invalid for option "hints"'
|
|
};
|
|
const options = {
|
|
hints: 100,
|
|
family: 0,
|
|
all: false
|
|
};
|
|
|
|
common.expectsError(() => { dnsPromises.lookup(false, options); }, err);
|
|
common.expectsError(() => {
|
|
dns.lookup(false, options, common.mustNotCall());
|
|
}, err);
|
|
}
|
|
|
|
{
|
|
const err = {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: TypeError,
|
|
message: 'The value "20" is invalid for option "family"'
|
|
};
|
|
const options = {
|
|
hints: 0,
|
|
family: 20,
|
|
all: false
|
|
};
|
|
|
|
common.expectsError(() => { dnsPromises.lookup(false, options); }, err);
|
|
common.expectsError(() => {
|
|
dns.lookup(false, options, common.mustNotCall());
|
|
}, err);
|
|
}
|
|
|
|
(async function() {
|
|
let res;
|
|
|
|
res = await dnsPromises.lookup(false, {
|
|
hints: 0,
|
|
family: 0,
|
|
all: true
|
|
});
|
|
assert.deepStrictEqual(res, []);
|
|
|
|
res = await dnsPromises.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: true
|
|
});
|
|
assert.deepStrictEqual(res, [{ address: '127.0.0.1', family: 4 }]);
|
|
|
|
res = await dnsPromises.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: false
|
|
});
|
|
assert.deepStrictEqual(res, { address: '127.0.0.1', family: 4 });
|
|
})();
|
|
|
|
dns.lookup(false, {
|
|
hints: 0,
|
|
family: 0,
|
|
all: true
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, []);
|
|
assert.strictEqual(addressType, undefined);
|
|
}));
|
|
|
|
dns.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: true
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, [{
|
|
address: '127.0.0.1',
|
|
family: 4
|
|
}]);
|
|
assert.strictEqual(addressType, undefined);
|
|
}));
|
|
|
|
dns.lookup('127.0.0.1', {
|
|
hints: 0,
|
|
family: 4,
|
|
all: false
|
|
}, common.mustCall((error, result, addressType) => {
|
|
assert.ifError(error);
|
|
assert.deepStrictEqual(result, '127.0.0.1');
|
|
assert.strictEqual(addressType, 4);
|
|
}));
|
|
|
|
let tickValue = 0;
|
|
|
|
dns.lookup('example.com', common.mustCall((error, result, addressType) => {
|
|
assert(error);
|
|
assert.strictEqual(tickValue, 1);
|
|
assert.strictEqual(error.code, 'ENOENT');
|
|
const descriptor = Object.getOwnPropertyDescriptor(error, 'message');
|
|
// The error message should be non-enumerable.
|
|
assert.strictEqual(descriptor.enumerable, false);
|
|
}));
|
|
|
|
// Make sure that the error callback is called
|
|
// on next tick.
|
|
tickValue = 1;
|