mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 17:57:53 +00:00
90e8f79f65
Constants ought to be constant. The primary goal of this commit is to
make constants exposed in require('constants') immutable, as they were
prior to node@7.0.0, and as the constants exposed on fs.constants,
crypto.constants, etc. are.
Since this is implemented by using Object.freeze, it also has the side
effect of making the entire exports of require('constants') immutable,
so no new constants can be defined on the object in userland.
PR-URL: https://github.com/nodejs/node/pull/19813
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
29 lines
768 B
JavaScript
29 lines
768 B
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const binding = process.binding('constants');
|
|
const constants = require('constants');
|
|
const assert = require('assert');
|
|
|
|
assert.ok(binding);
|
|
assert.ok(binding.os);
|
|
assert.ok(binding.os.signals);
|
|
assert.ok(binding.os.errno);
|
|
assert.ok(binding.fs);
|
|
assert.ok(binding.crypto);
|
|
|
|
['os', 'fs', 'crypto'].forEach((l) => {
|
|
Object.keys(binding[l]).forEach((k) => {
|
|
if (typeof binding[l][k] === 'object') { // errno and signals
|
|
Object.keys(binding[l][k]).forEach((j) => {
|
|
assert.strictEqual(binding[l][k][j], constants[j]);
|
|
});
|
|
}
|
|
if (l !== 'os') { // top level os constant isn't currently copied
|
|
assert.strictEqual(binding[l][k], constants[k]);
|
|
}
|
|
});
|
|
});
|
|
|
|
assert.ok(Object.isFrozen(constants));
|