mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 19:14:16 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
52 lines
1.4 KiB
JavaScript
52 lines
1.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const child_process = require('child_process');
|
|
const { promisify } = require('util');
|
|
|
|
const exec = promisify(child_process.exec);
|
|
const execFile = promisify(child_process.execFile);
|
|
|
|
{
|
|
exec(`${process.execPath} -p 42`).then(common.mustCall((obj) => {
|
|
assert.deepStrictEqual(obj, { stdout: '42\n', stderr: '' });
|
|
}));
|
|
}
|
|
|
|
{
|
|
execFile(process.execPath, ['-p', '42']).then(common.mustCall((obj) => {
|
|
assert.deepStrictEqual(obj, { stdout: '42\n', stderr: '' });
|
|
}));
|
|
}
|
|
|
|
{
|
|
exec('doesntexist').catch(common.mustCall((err) => {
|
|
assert(err.message.includes('doesntexist'));
|
|
}));
|
|
}
|
|
|
|
{
|
|
execFile('doesntexist', ['-p', '42']).catch(common.mustCall((err) => {
|
|
assert(err.message.includes('doesntexist'));
|
|
}));
|
|
}
|
|
const failingCodeWithStdoutErr =
|
|
'console.log(42);console.error(43);process.exit(1)';
|
|
{
|
|
exec(`${process.execPath} -e "${failingCodeWithStdoutErr}"`)
|
|
.catch(common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 1);
|
|
assert.strictEqual(err.stdout, '42\n');
|
|
assert.strictEqual(err.stderr, '43\n');
|
|
}));
|
|
}
|
|
|
|
{
|
|
execFile(process.execPath, ['-e', failingCodeWithStdoutErr])
|
|
.catch(common.mustCall((err) => {
|
|
assert.strictEqual(err.code, 1);
|
|
assert.strictEqual(err.stdout, '42\n');
|
|
assert.strictEqual(err.stderr, '43\n');
|
|
}));
|
|
}
|