mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00

Add AggregateError support to fsPromises, instead of swallowing errors if fs.close throws. PR-URL: https://github.com/nodejs/node/pull/38259 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
62 lines
1.6 KiB
JavaScript
62 lines
1.6 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
// The following tests validate aggregate errors are thrown correctly
|
|
// when both an operation and close throw.
|
|
|
|
const path = require('path');
|
|
const {
|
|
readFile,
|
|
writeFile,
|
|
truncate,
|
|
lchmod,
|
|
} = require('fs/promises');
|
|
const {
|
|
FileHandle,
|
|
} = require('internal/fs/promises');
|
|
|
|
const assert = require('assert');
|
|
const originalFd = Object.getOwnPropertyDescriptor(FileHandle.prototype, 'fd');
|
|
|
|
let count = 0;
|
|
async function createFile() {
|
|
const filePath = path.join(tmpdir.path, `op_errors_${++count}.txt`);
|
|
await writeFile(filePath, 'content');
|
|
return filePath;
|
|
}
|
|
|
|
async function checkOperationError(op) {
|
|
try {
|
|
const filePath = await createFile();
|
|
Object.defineProperty(FileHandle.prototype, 'fd', {
|
|
get: function() {
|
|
// Verify that close is called when an error is thrown
|
|
this.close = common.mustCall(this.close);
|
|
const opError = new Error('INTERNAL_ERROR');
|
|
opError.code = 123;
|
|
throw opError;
|
|
}
|
|
});
|
|
|
|
await assert.rejects(op(filePath), {
|
|
name: 'Error',
|
|
message: 'INTERNAL_ERROR',
|
|
code: 123,
|
|
});
|
|
} finally {
|
|
Object.defineProperty(FileHandle.prototype, 'fd', originalFd);
|
|
}
|
|
}
|
|
(async function() {
|
|
tmpdir.refresh();
|
|
await checkOperationError((filePath) => truncate(filePath));
|
|
await checkOperationError((filePath) => readFile(filePath));
|
|
await checkOperationError((filePath) => writeFile(filePath, '123'));
|
|
if (common.isOSX) {
|
|
await checkOperationError((filePath) => lchmod(filePath, 0o777));
|
|
}
|
|
})().then(common.mustCall());
|