mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00

This commit updates the test runner to wait for suites to finish building before starting any tests. This is necessary when test filtering is enabled, as suites may transition from filtered to not filtered depending on what is inside of them. Fixes: https://github.com/nodejs/node/issues/54084 Fixes: https://github.com/nodejs/node/issues/54154 PR-URL: https://github.com/nodejs/node/pull/54423 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
338 lines
9.5 KiB
JavaScript
338 lines
9.5 KiB
JavaScript
'use strict';
|
|
const {
|
|
ArrayPrototypeForEach,
|
|
ArrayPrototypePush,
|
|
FunctionPrototypeBind,
|
|
PromiseResolve,
|
|
SafeMap,
|
|
SafePromiseAllReturnVoid,
|
|
} = primordials;
|
|
const { getCallerLocation } = internalBinding('util');
|
|
const {
|
|
createHook,
|
|
executionAsyncId,
|
|
} = require('async_hooks');
|
|
const { relative } = require('path');
|
|
const {
|
|
codes: {
|
|
ERR_TEST_FAILURE,
|
|
},
|
|
} = require('internal/errors');
|
|
const { exitCodes: { kGenericUserError } } = internalBinding('errors');
|
|
const { kCancelledByParent, Test, Suite } = require('internal/test_runner/test');
|
|
const {
|
|
parseCommandLine,
|
|
reporterScope,
|
|
shouldColorizeTestFiles,
|
|
} = require('internal/test_runner/utils');
|
|
const { queueMicrotask } = require('internal/process/task_queues');
|
|
const { createDeferredPromise } = require('internal/util');
|
|
const { bigint: hrtime } = process.hrtime;
|
|
const resolvedPromise = PromiseResolve();
|
|
const testResources = new SafeMap();
|
|
let globalRoot;
|
|
|
|
testResources.set(reporterScope.asyncId(), reporterScope);
|
|
|
|
function createTestTree(rootTestOptions, globalOptions) {
|
|
const buildPhaseDeferred = createDeferredPromise();
|
|
const harness = {
|
|
__proto__: null,
|
|
buildPromise: buildPhaseDeferred.promise,
|
|
buildSuites: [],
|
|
isWaitingForBuildPhase: false,
|
|
bootstrapPromise: resolvedPromise,
|
|
watching: false,
|
|
config: globalOptions,
|
|
coverage: null,
|
|
resetCounters() {
|
|
harness.counters = {
|
|
__proto__: null,
|
|
all: 0,
|
|
failed: 0,
|
|
passed: 0,
|
|
cancelled: 0,
|
|
skipped: 0,
|
|
todo: 0,
|
|
topLevel: 0,
|
|
suites: 0,
|
|
};
|
|
},
|
|
counters: null,
|
|
shouldColorizeTestFiles: shouldColorizeTestFiles(globalOptions.destinations),
|
|
teardown: null,
|
|
snapshotManager: null,
|
|
async waitForBuildPhase() {
|
|
if (harness.buildSuites.length > 0) {
|
|
await SafePromiseAllReturnVoid(harness.buildSuites);
|
|
}
|
|
|
|
buildPhaseDeferred.resolve();
|
|
},
|
|
};
|
|
|
|
harness.resetCounters();
|
|
globalRoot = new Test({
|
|
__proto__: null,
|
|
...rootTestOptions,
|
|
harness,
|
|
name: '<root>',
|
|
});
|
|
setupProcessState(globalRoot, globalOptions, harness);
|
|
globalRoot.startTime = hrtime();
|
|
return globalRoot;
|
|
}
|
|
|
|
function createProcessEventHandler(eventName, rootTest) {
|
|
return (err) => {
|
|
if (rootTest.harness.bootstrapPromise) {
|
|
// Something went wrong during the asynchronous portion of bootstrapping
|
|
// the test runner. Since the test runner is not setup properly, we can't
|
|
// do anything but throw the error.
|
|
throw err;
|
|
}
|
|
|
|
const test = testResources.get(executionAsyncId());
|
|
|
|
// Check if this error is coming from a reporter. If it is, throw it.
|
|
if (test === reporterScope) {
|
|
throw err;
|
|
}
|
|
|
|
// Check if this error is coming from a test or test hook. If it is, fail the test.
|
|
if (!test || test.finished || test.hookType) {
|
|
// If the test is already finished or the resource that created the error
|
|
// is not mapped to a Test, report this as a top level diagnostic.
|
|
let msg;
|
|
|
|
if (test) {
|
|
const name = test.hookType ? `Test hook "${test.hookType}"` : `Test "${test.name}"`;
|
|
let locInfo = '';
|
|
if (test.loc) {
|
|
const relPath = relative(process.cwd(), test.loc.file);
|
|
locInfo = ` at ${relPath}:${test.loc.line}:${test.loc.column}`;
|
|
}
|
|
|
|
msg = `Error: ${name}${locInfo} generated asynchronous ` +
|
|
'activity after the test ended. This activity created the error ' +
|
|
`"${err}" and would have caused the test to fail, but instead ` +
|
|
`triggered an ${eventName} event.`;
|
|
} else {
|
|
msg = 'Error: A resource generated asynchronous activity after ' +
|
|
`the test ended. This activity created the error "${err}" which ` +
|
|
`triggered an ${eventName} event, caught by the test runner.`;
|
|
}
|
|
|
|
rootTest.diagnostic(msg);
|
|
process.exitCode = kGenericUserError;
|
|
return;
|
|
}
|
|
|
|
test.fail(new ERR_TEST_FAILURE(err, eventName));
|
|
test.abortController.abort();
|
|
};
|
|
}
|
|
|
|
function configureCoverage(rootTest, globalOptions) {
|
|
if (!globalOptions.coverage) {
|
|
return null;
|
|
}
|
|
|
|
const { setupCoverage } = require('internal/test_runner/coverage');
|
|
|
|
try {
|
|
return setupCoverage(globalOptions);
|
|
} catch (err) {
|
|
const msg = `Warning: Code coverage could not be enabled. ${err}`;
|
|
|
|
rootTest.diagnostic(msg);
|
|
process.exitCode = kGenericUserError;
|
|
}
|
|
}
|
|
|
|
function collectCoverage(rootTest, coverage) {
|
|
if (!coverage) {
|
|
return null;
|
|
}
|
|
|
|
let summary = null;
|
|
|
|
try {
|
|
summary = coverage.summary();
|
|
coverage.cleanup();
|
|
} catch (err) {
|
|
const op = summary ? 'clean up' : 'report';
|
|
const msg = `Warning: Could not ${op} code coverage. ${err}`;
|
|
|
|
rootTest.diagnostic(msg);
|
|
process.exitCode = kGenericUserError;
|
|
}
|
|
|
|
return summary;
|
|
}
|
|
|
|
function setupProcessState(root, globalOptions) {
|
|
const hook = createHook({
|
|
__proto__: null,
|
|
init(asyncId, type, triggerAsyncId, resource) {
|
|
if (resource instanceof Test) {
|
|
testResources.set(asyncId, resource);
|
|
return;
|
|
}
|
|
|
|
const parent = testResources.get(triggerAsyncId);
|
|
|
|
if (parent !== undefined) {
|
|
testResources.set(asyncId, parent);
|
|
}
|
|
},
|
|
destroy(asyncId) {
|
|
testResources.delete(asyncId);
|
|
},
|
|
});
|
|
|
|
hook.enable();
|
|
|
|
const exceptionHandler =
|
|
createProcessEventHandler('uncaughtException', root);
|
|
const rejectionHandler =
|
|
createProcessEventHandler('unhandledRejection', root);
|
|
const coverage = configureCoverage(root, globalOptions);
|
|
const exitHandler = async () => {
|
|
if (root.subtests.length === 0 && (root.hooks.before.length > 0 || root.hooks.after.length > 0)) {
|
|
// Run global before/after hooks in case there are no tests
|
|
await root.run();
|
|
}
|
|
root.postRun(new ERR_TEST_FAILURE(
|
|
'Promise resolution is still pending but the event loop has already resolved',
|
|
kCancelledByParent));
|
|
|
|
hook.disable();
|
|
process.removeListener('uncaughtException', exceptionHandler);
|
|
process.removeListener('unhandledRejection', rejectionHandler);
|
|
process.removeListener('beforeExit', exitHandler);
|
|
if (globalOptions.isTestRunner) {
|
|
process.removeListener('SIGINT', terminationHandler);
|
|
process.removeListener('SIGTERM', terminationHandler);
|
|
}
|
|
};
|
|
|
|
const terminationHandler = () => {
|
|
exitHandler();
|
|
process.exit();
|
|
};
|
|
|
|
process.on('uncaughtException', exceptionHandler);
|
|
process.on('unhandledRejection', rejectionHandler);
|
|
process.on('beforeExit', exitHandler);
|
|
// TODO(MoLow): Make it configurable to hook when isTestRunner === false.
|
|
if (globalOptions.isTestRunner) {
|
|
process.on('SIGINT', terminationHandler);
|
|
process.on('SIGTERM', terminationHandler);
|
|
}
|
|
|
|
root.harness.coverage = FunctionPrototypeBind(collectCoverage, null, root, coverage);
|
|
root.harness.teardown = exitHandler;
|
|
}
|
|
|
|
function lazyBootstrapRoot() {
|
|
if (!globalRoot) {
|
|
// This is where the test runner is bootstrapped when node:test is used
|
|
// without the --test flag or the run() API.
|
|
const rootTestOptions = {
|
|
__proto__: null,
|
|
entryFile: process.argv?.[1],
|
|
};
|
|
const globalOptions = parseCommandLine();
|
|
createTestTree(rootTestOptions, globalOptions);
|
|
globalRoot.reporter.on('test:fail', (data) => {
|
|
if (data.todo === undefined || data.todo === false) {
|
|
process.exitCode = kGenericUserError;
|
|
}
|
|
});
|
|
globalRoot.harness.bootstrapPromise = globalOptions.setup(globalRoot.reporter);
|
|
}
|
|
return globalRoot;
|
|
}
|
|
|
|
async function startSubtestAfterBootstrap(subtest) {
|
|
if (subtest.root.harness.buildPromise) {
|
|
if (subtest.root.harness.bootstrapPromise) {
|
|
await subtest.root.harness.bootstrapPromise;
|
|
subtest.root.harness.bootstrapPromise = null;
|
|
}
|
|
|
|
if (subtest.buildSuite) {
|
|
ArrayPrototypePush(subtest.root.harness.buildSuites, subtest.buildSuite);
|
|
}
|
|
|
|
if (!subtest.root.harness.isWaitingForBuildPhase) {
|
|
subtest.root.harness.isWaitingForBuildPhase = true;
|
|
queueMicrotask(() => {
|
|
subtest.root.harness.waitForBuildPhase();
|
|
});
|
|
}
|
|
|
|
await subtest.root.harness.buildPromise;
|
|
subtest.root.harness.buildPromise = null;
|
|
}
|
|
|
|
await subtest.start();
|
|
}
|
|
|
|
function runInParentContext(Factory) {
|
|
function run(name, options, fn, overrides) {
|
|
const parent = testResources.get(executionAsyncId()) || lazyBootstrapRoot();
|
|
const subtest = parent.createSubtest(Factory, name, options, fn, overrides);
|
|
if (parent instanceof Suite) {
|
|
return PromiseResolve();
|
|
}
|
|
|
|
return startSubtestAfterBootstrap(subtest);
|
|
}
|
|
|
|
const test = (name, options, fn) => {
|
|
const overrides = {
|
|
__proto__: null,
|
|
loc: getCallerLocation(),
|
|
};
|
|
|
|
return run(name, options, fn, overrides);
|
|
};
|
|
ArrayPrototypeForEach(['skip', 'todo', 'only'], (keyword) => {
|
|
test[keyword] = (name, options, fn) => {
|
|
const overrides = {
|
|
__proto__: null,
|
|
[keyword]: true,
|
|
loc: getCallerLocation(),
|
|
};
|
|
|
|
return run(name, options, fn, overrides);
|
|
};
|
|
});
|
|
return test;
|
|
}
|
|
|
|
function hook(hook) {
|
|
return (fn, options) => {
|
|
const parent = testResources.get(executionAsyncId()) || lazyBootstrapRoot();
|
|
parent.createHook(hook, fn, {
|
|
__proto__: null,
|
|
...options,
|
|
parent,
|
|
hookType: hook,
|
|
loc: getCallerLocation(),
|
|
});
|
|
};
|
|
}
|
|
|
|
module.exports = {
|
|
createTestTree,
|
|
test: runInParentContext(Test),
|
|
suite: runInParentContext(Suite),
|
|
before: hook('before'),
|
|
after: hook('after'),
|
|
beforeEach: hook('beforeEach'),
|
|
afterEach: hook('afterEach'),
|
|
};
|