mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 16:22:29 +00:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
69 lines
2.7 KiB
JavaScript
69 lines
2.7 KiB
JavaScript
'use strict';
|
|
// tests zlib streams with truncated compressed input
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const zlib = require('zlib');
|
|
|
|
const inputString = 'ΩΩLorem ipsum dolor sit amet, consectetur adipiscing eli' +
|
|
't. Morbi faucibus, purus at gravida dictum, libero arcu ' +
|
|
'convallis lacus, in commodo libero metus eu nisi. Nullam' +
|
|
' commodo, neque nec porta placerat, nisi est fermentum a' +
|
|
'ugue, vitae gravida tellus sapien sit amet tellus. Aenea' +
|
|
'n non diam orci. Proin quis elit turpis. Suspendisse non' +
|
|
' diam ipsum. Suspendisse nec ullamcorper odio. Vestibulu' +
|
|
'm arcu mi, sodales non suscipit id, ultrices ut massa. S' +
|
|
'ed ac sem sit amet arcu malesuada fermentum. Nunc sed. ';
|
|
|
|
const errMessage = /unexpected end of file/;
|
|
|
|
[
|
|
{ comp: 'gzip', decomp: 'gunzip', decompSync: 'gunzipSync' },
|
|
{ comp: 'gzip', decomp: 'unzip', decompSync: 'unzipSync' },
|
|
{ comp: 'deflate', decomp: 'inflate', decompSync: 'inflateSync' },
|
|
{ comp: 'deflateRaw', decomp: 'inflateRaw', decompSync: 'inflateRawSync' }
|
|
].forEach(function(methods) {
|
|
zlib[methods.comp](inputString, function(err, compressed) {
|
|
assert.ifError(err);
|
|
const truncated = compressed.slice(0, compressed.length / 2);
|
|
const toUTF8 = (buffer) => buffer.toString('utf-8');
|
|
|
|
// sync sanity
|
|
assert.doesNotThrow(function() {
|
|
const decompressed = zlib[methods.decompSync](compressed);
|
|
assert.strictEqual(toUTF8(decompressed), inputString);
|
|
});
|
|
|
|
// async sanity
|
|
zlib[methods.decomp](compressed, function(err, result) {
|
|
assert.ifError(err);
|
|
assert.strictEqual(toUTF8(result), inputString);
|
|
});
|
|
|
|
// sync truncated input test
|
|
assert.throws(function() {
|
|
zlib[methods.decompSync](truncated);
|
|
}, errMessage);
|
|
|
|
// async truncated input test
|
|
zlib[methods.decomp](truncated, function(err, result) {
|
|
assert(errMessage.test(err.message));
|
|
});
|
|
|
|
const syncFlushOpt = { finishFlush: zlib.constants.Z_SYNC_FLUSH };
|
|
|
|
// sync truncated input test, finishFlush = Z_SYNC_FLUSH
|
|
assert.doesNotThrow(function() {
|
|
const result = toUTF8(zlib[methods.decompSync](truncated, syncFlushOpt));
|
|
assert.strictEqual(result, inputString.substr(0, result.length));
|
|
});
|
|
|
|
// async truncated input test, finishFlush = Z_SYNC_FLUSH
|
|
zlib[methods.decomp](truncated, syncFlushOpt, function(err, decompressed) {
|
|
assert.ifError(err);
|
|
const result = toUTF8(decompressed);
|
|
assert.strictEqual(result, inputString.substr(0, result.length));
|
|
});
|
|
});
|
|
});
|