mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00

Adds a new `../common/fixtures' module to begin normalizing `test/fixtures` use. Our test code is a bit inconsistent with regards to use of the fixtures directory. Some code uses `path.join()`, some code uses string concats, some other code uses template strings, etc. In mnay cases, significant duplication of code is seen when accessing fixture files, etc. This updates many (but by no means all) of the tests in the test suite to use the new consistent API. There are still many more to update, which would make an excelent Code-n-Learn exercise. PR-URL: https://github.com/nodejs/node/pull/14332 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michaël Zasso <targos@protonmail.com>
86 lines
2.7 KiB
JavaScript
86 lines
2.7 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasIntl) {
|
|
// A handful of the tests fail when ICU is not included.
|
|
common.skip('missing Intl');
|
|
}
|
|
|
|
const fixtures = require('../common/fixtures');
|
|
const { URL } = require('url');
|
|
const { test, assert_equals, assert_throws } = require('../common/wpt');
|
|
|
|
const request = {
|
|
response: require(fixtures.path('url-toascii'))
|
|
};
|
|
|
|
/* The following tests are copied from WPT. Modifications to them should be
|
|
upstreamed first. Refs:
|
|
https://github.com/w3c/web-platform-tests/blob/4839a0a804/url/toascii.window.js
|
|
License: http://www.w3.org/Consortium/Legal/2008/04-testsuite-copyright.html
|
|
*/
|
|
/* eslint-disable */
|
|
// async_test(t => {
|
|
// const request = new XMLHttpRequest()
|
|
// request.open("GET", "toascii.json")
|
|
// request.send()
|
|
// request.responseType = "json"
|
|
// request.onload = t.step_func_done(() => {
|
|
runTests(request.response)
|
|
// })
|
|
// }, "Loading data…")
|
|
|
|
function makeURL(type, input) {
|
|
input = "https://" + input + "/x"
|
|
if(type === "url") {
|
|
return new URL(input)
|
|
} else {
|
|
const url = document.createElement(type)
|
|
url.href = input
|
|
return url
|
|
}
|
|
}
|
|
|
|
function runTests(tests) {
|
|
for(var i = 0, l = tests.length; i < l; i++) {
|
|
let hostTest = tests[i]
|
|
if (typeof hostTest === "string") {
|
|
continue // skip comments
|
|
}
|
|
const typeName = { "url": "URL", "a": "<a>", "area": "<area>" }
|
|
// ;["url", "a", "area"].forEach((type) => {
|
|
;["url"].forEach((type) => {
|
|
test(() => {
|
|
if(hostTest.output !== null) {
|
|
const url = makeURL("url", hostTest.input)
|
|
assert_equals(url.host, hostTest.output)
|
|
assert_equals(url.hostname, hostTest.output)
|
|
assert_equals(url.pathname, "/x")
|
|
assert_equals(url.href, "https://" + hostTest.output + "/x")
|
|
} else {
|
|
if(type === "url") {
|
|
assert_throws(new TypeError, () => makeURL("url", hostTest.input))
|
|
} else {
|
|
const url = makeURL(type, hostTest.input)
|
|
assert_equals(url.host, "")
|
|
assert_equals(url.hostname, "")
|
|
assert_equals(url.pathname, "")
|
|
assert_equals(url.href, "https://" + hostTest.input + "/x")
|
|
}
|
|
}
|
|
}, hostTest.input + " (using " + typeName[type] + ")")
|
|
;["host", "hostname"].forEach((val) => {
|
|
test(() => {
|
|
const url = makeURL(type, "x")
|
|
url[val] = hostTest.input
|
|
if(hostTest.output !== null) {
|
|
assert_equals(url[val], hostTest.output)
|
|
} else {
|
|
assert_equals(url[val], "x")
|
|
}
|
|
}, hostTest.input + " (using " + typeName[type] + "." + val + ")")
|
|
})
|
|
})
|
|
}
|
|
}
|
|
/* eslint-enable */
|