mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 02:06:12 +00:00

Remove the CopyProperties() hack in the vm module, i.e., Contextify.
Use different V8 API methods, that allow interception of
DefineProperty() and do not flatten accessor descriptors to
property descriptors.
Move many known issues to test cases. Factor out the last test in
test-vm-context.js for
https://github.com/nodejs/node/issues/10223
into its own file, test-vm-strict-assign.js.
Part of this CL is taken from a stalled PR by
https://github.com/AnnaMag
https://github.com/nodejs/node/pull/13265
This PR requires a backport of
37a3a15c3e
PR-URL: https://github.com/nodejs/node/pull/16293
Fixes: https://github.com/nodejs/node/issues/2734
Fixes: https://github.com/nodejs/node/issues/10223
Fixes: https://github.com/nodejs/node/issues/11803
Fixes: https://github.com/nodejs/node/issues/11902
Ref: https://github.com/nodejs/node/issues/6283
Ref: https://github.com/nodejs/node/pull/15114
Ref: https://github.com/nodejs/node/pull/13265
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
109 lines
4.0 KiB
JavaScript
109 lines
4.0 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const vm = require('vm');
|
|
const Script = vm.Script;
|
|
let script = new Script('"passed";');
|
|
|
|
// Run in a new empty context
|
|
let context = vm.createContext();
|
|
let result = script.runInContext(context);
|
|
assert.strictEqual('passed', result);
|
|
|
|
// Create a new pre-populated context
|
|
context = vm.createContext({ 'foo': 'bar', 'thing': 'lala' });
|
|
assert.strictEqual('bar', context.foo);
|
|
assert.strictEqual('lala', context.thing);
|
|
|
|
// Test updating context
|
|
script = new Script('foo = 3;');
|
|
result = script.runInContext(context);
|
|
assert.strictEqual(3, context.foo);
|
|
assert.strictEqual('lala', context.thing);
|
|
|
|
// Issue GH-227:
|
|
assert.throws(() => {
|
|
vm.runInNewContext('', null, 'some.js');
|
|
}, /^TypeError: sandbox must be an object$/);
|
|
|
|
// Issue GH-1140:
|
|
// Test runInContext signature
|
|
let gh1140Exception;
|
|
try {
|
|
vm.runInContext('throw new Error()', context, 'expected-filename.js');
|
|
} catch (e) {
|
|
gh1140Exception = e;
|
|
assert.ok(/expected-filename/.test(e.stack),
|
|
'expected appearance of filename in Error stack');
|
|
}
|
|
assert.ok(gh1140Exception,
|
|
'expected exception from runInContext signature test');
|
|
|
|
// GH-558, non-context argument segfaults / raises assertion
|
|
const nonContextualSandboxErrorMsg =
|
|
/^TypeError: contextifiedSandbox argument must be an object\.$/;
|
|
const contextifiedSandboxErrorMsg =
|
|
/^TypeError: sandbox argument must have been converted to a context\.$/;
|
|
[
|
|
[undefined, nonContextualSandboxErrorMsg],
|
|
[null, nonContextualSandboxErrorMsg], [0, nonContextualSandboxErrorMsg],
|
|
[0.0, nonContextualSandboxErrorMsg], ['', nonContextualSandboxErrorMsg],
|
|
[{}, contextifiedSandboxErrorMsg], [[], contextifiedSandboxErrorMsg]
|
|
].forEach((e) => {
|
|
assert.throws(() => { script.runInContext(e[0]); }, e[1]);
|
|
assert.throws(() => { vm.runInContext('', e[0]); }, e[1]);
|
|
});
|
|
|
|
// Issue GH-693:
|
|
// Test RegExp as argument to assert.throws
|
|
script = vm.createScript('const assert = require(\'assert\'); assert.throws(' +
|
|
'function() { throw "hello world"; }, /hello/);',
|
|
'some.js');
|
|
script.runInNewContext({ require: require });
|
|
|
|
// Issue GH-7529
|
|
script = vm.createScript('delete b');
|
|
let ctx = {};
|
|
Object.defineProperty(ctx, 'b', { configurable: false });
|
|
ctx = vm.createContext(ctx);
|
|
assert.strictEqual(script.runInContext(ctx), false);
|
|
|
|
// Error on the first line of a module should
|
|
// have the correct line and column number
|
|
assert.throws(() => {
|
|
vm.runInContext(' throw new Error()', context, {
|
|
filename: 'expected-filename.js',
|
|
lineOffset: 32,
|
|
columnOffset: 123
|
|
});
|
|
}, (err) => {
|
|
return /^ \^/m.test(err.stack) &&
|
|
/expected-filename\.js:33:131/.test(err.stack);
|
|
}, 'Expected appearance of proper offset in Error stack');
|
|
|
|
// https://github.com/nodejs/node/issues/6158
|
|
ctx = new Proxy({}, {});
|
|
assert.strictEqual(typeof vm.runInNewContext('String', ctx), 'function');
|