mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 18:44:40 +00:00

The motivation for this commit is that these two test fail on systems that have different Name Service Switch configuration settings. A concrete example of this is when using Red Hat Enterprise Linux (RHEL) 7. If Name Service Switch is available on the operating system then it might be configured differently (/etc/nsswitch.conf). If the system is configured with no dns the error code will be AI_AGAIN, but if there are more services after the dns entry, for example some linux distributions skip a myhostname service by default which would still produce the ENOTFOUND error. This commit suggests checking for either ENOTFOUND or EAI_AGAIN to accommodate systems like the ones described above. The references below indicate that others have run, or are running, into this aswell. Refs: https://github.com/nodejs/node/issues/12075 Refs: https://github.com/nodejs/help/issues/687 Refs: https://github.com/nodejs/node/issues/15825 PR-URL: https://github.com/nodejs/node/pull/16378 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
46 lines
1.2 KiB
JavaScript
46 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
|
|
if (!common.hasIPv6)
|
|
common.skip('no IPv6 support');
|
|
|
|
const assert = require('assert');
|
|
const tls = require('tls');
|
|
const dns = require('dns');
|
|
|
|
function runTest() {
|
|
const ciphers = 'AECDH-NULL-SHA';
|
|
tls.createServer({ ciphers }, common.mustCall(function() {
|
|
this.close();
|
|
})).listen(0, '::1', common.mustCall(function() {
|
|
const options = {
|
|
host: 'localhost',
|
|
port: this.address().port,
|
|
family: 6,
|
|
ciphers: ciphers,
|
|
rejectUnauthorized: false,
|
|
};
|
|
// Will fail with ECONNREFUSED if the address family is not honored.
|
|
tls.connect(options).once('secureConnect', common.mustCall(function() {
|
|
assert.strictEqual('::1', this.remoteAddress);
|
|
this.destroy();
|
|
}));
|
|
}));
|
|
}
|
|
|
|
dns.lookup('localhost', { family: 6, all: true }, (err, addresses) => {
|
|
if (err) {
|
|
if (err.code === 'ENOTFOUND' || err.code === 'EAI_AGAIN')
|
|
common.skip('localhost does not resolve to ::1');
|
|
|
|
throw err;
|
|
}
|
|
|
|
if (addresses.some((val) => val.address === '::1'))
|
|
runTest();
|
|
else
|
|
common.skip('localhost does not resolve to ::1');
|
|
});
|