mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 16:22:29 +00:00
380929ec0c
This change removes `common.noop` from the Node.js internal testing
common module.
Over the last few weeks, I've grown to dislike the `common.noop`
abstraction.
First, new (and experienced) contributors are unaware of it and so it
results in a large number of low-value nits on PRs. It also increases
the number of things newcomers and infrequent contributors have to be
aware of to be effective on the project.
Second, it is confusing. Is it a singleton/property or a getter? Which
should be expected? This can lead to subtle and hard-to-find bugs. (To
my knowledge, none have landed on master. But I also think it's only a
matter of time.)
Third, the abstraction is low-value in my opinion. What does it really
get us? A case could me made that it is without value at all.
Lastly, and this is minor, but the abstraction is wordier than not using
the abstraction. `common.noop` doesn't save anything over `() => {}`.
So, I propose removing it.
PR-URL: https://github.com/nodejs/node/pull/12822
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
71 lines
1.9 KiB
JavaScript
71 lines
1.9 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const Readable = require('stream').Readable;
|
|
|
|
const readable = new Readable({
|
|
read: () => {}
|
|
});
|
|
|
|
// Initialized to false.
|
|
assert.strictEqual(readable._readableState.emittedReadable, false);
|
|
|
|
readable.on('readable', common.mustCall(() => {
|
|
// emittedReadable should be true when the readable event is emitted
|
|
assert.strictEqual(readable._readableState.emittedReadable, true);
|
|
readable.read();
|
|
// emittedReadable is reset to false during read()
|
|
assert.strictEqual(readable._readableState.emittedReadable, false);
|
|
}, 4));
|
|
|
|
// When the first readable listener is just attached,
|
|
// emittedReadable should be false
|
|
assert.strictEqual(readable._readableState.emittedReadable, false);
|
|
|
|
// Each one of these should trigger a readable event.
|
|
process.nextTick(common.mustCall(() => {
|
|
readable.push('foo');
|
|
}));
|
|
process.nextTick(common.mustCall(() => {
|
|
readable.push('bar');
|
|
}));
|
|
process.nextTick(common.mustCall(() => {
|
|
readable.push('quo');
|
|
}));
|
|
process.nextTick(common.mustCall(() => {
|
|
readable.push(null);
|
|
}));
|
|
|
|
const noRead = new Readable({
|
|
read: () => {}
|
|
});
|
|
|
|
noRead.on('readable', common.mustCall(() => {
|
|
// emittedReadable should be true when the readable event is emitted
|
|
assert.strictEqual(noRead._readableState.emittedReadable, true);
|
|
noRead.read(0);
|
|
// emittedReadable is not reset during read(0)
|
|
assert.strictEqual(noRead._readableState.emittedReadable, true);
|
|
}));
|
|
|
|
noRead.push('foo');
|
|
noRead.push(null);
|
|
|
|
const flowing = new Readable({
|
|
read: () => {}
|
|
});
|
|
|
|
flowing.on('data', common.mustCall(() => {
|
|
// When in flowing mode, emittedReadable is always false.
|
|
assert.strictEqual(flowing._readableState.emittedReadable, false);
|
|
flowing.read();
|
|
assert.strictEqual(flowing._readableState.emittedReadable, false);
|
|
}, 3));
|
|
|
|
flowing.push('foooo');
|
|
flowing.push('bar');
|
|
flowing.push('quo');
|
|
process.nextTick(common.mustCall(() => {
|
|
flowing.push(null);
|
|
}));
|