mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00
7f55349079
Covert lib/net.js over to using lib/internal/errors.js - Replace thrown errors in lib/net.js with errors from lib/internal/errors. The ERR_INVALID_OPT_VALUE error have been used in the Server.prototype.listen() method - Update tests according to the above modifications PR-URL: https://github.com/nodejs/node/pull/14782 Refs: https://github.com/nodejs/node/issues/11273 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
79 lines
2.5 KiB
JavaScript
79 lines
2.5 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const net = require('net');
|
|
|
|
function close() { this.close(); }
|
|
|
|
{
|
|
// Test listen()
|
|
net.createServer().listen().on('listening', common.mustCall(close));
|
|
// Test listen(cb)
|
|
net.createServer().listen(common.mustCall(close));
|
|
// Test listen(port)
|
|
net.createServer().listen(0).on('listening', common.mustCall(close));
|
|
// Test listen({port})
|
|
net.createServer().listen({ port: 0 })
|
|
.on('listening', common.mustCall(close));
|
|
}
|
|
|
|
// Test listen(port, cb) and listen({port: port}, cb) combinations
|
|
const listenOnPort = [
|
|
(port, cb) => net.createServer().listen({ port }, cb),
|
|
(port, cb) => net.createServer().listen(port, cb)
|
|
];
|
|
|
|
{
|
|
const assertPort = () => {
|
|
return common.expectsError({
|
|
code: 'ERR_SOCKET_BAD_PORT',
|
|
type: RangeError
|
|
});
|
|
};
|
|
|
|
for (const listen of listenOnPort) {
|
|
// Arbitrary unused ports
|
|
listen('0', common.mustCall(close));
|
|
listen(0, common.mustCall(close));
|
|
listen(undefined, common.mustCall(close));
|
|
listen(null, common.mustCall(close));
|
|
// Test invalid ports
|
|
assert.throws(() => listen(-1, common.mustNotCall()), assertPort());
|
|
assert.throws(() => listen(NaN, common.mustNotCall()), assertPort());
|
|
assert.throws(() => listen(123.456, common.mustNotCall()), assertPort());
|
|
assert.throws(() => listen(65536, common.mustNotCall()), assertPort());
|
|
assert.throws(() => listen(1 / 0, common.mustNotCall()), assertPort());
|
|
assert.throws(() => listen(-1 / 0, common.mustNotCall()), assertPort());
|
|
}
|
|
// In listen(options, cb), port takes precedence over path
|
|
assert.throws(() => {
|
|
net.createServer().listen({ port: -1, path: common.PIPE },
|
|
common.mustNotCall());
|
|
}, assertPort());
|
|
}
|
|
|
|
{
|
|
function shouldFailToListen(options) {
|
|
const block = () => {
|
|
net.createServer().listen(options, common.mustNotCall());
|
|
};
|
|
assert.throws(block,
|
|
common.expectsError({
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
type: Error,
|
|
message: /^The value "{.*}" is invalid for option "options"$/
|
|
}));
|
|
}
|
|
|
|
shouldFailToListen(false, { port: false });
|
|
shouldFailToListen({ port: false });
|
|
shouldFailToListen(true);
|
|
shouldFailToListen({ port: true });
|
|
// Invalid fd as listen(handle)
|
|
shouldFailToListen({ fd: -1 });
|
|
// Invalid path in listen(options)
|
|
shouldFailToListen({ path: -1 });
|
|
// Host without port
|
|
shouldFailToListen({ host: 'localhost' });
|
|
}
|