mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 18:44:40 +00:00

Extensive re-work of http1 compatibility layer based on tests in express, on-finished and finalhandler. Fix handling of HEAD method to match http1. Adjust write, end, etc. to call writeHead as in http1 and as expected by user-land modules. Add socket proxy that instead uses the Http2Stream for the vast majority of socket interactions. Add and change tests to closer represent http1 behaviour. Refs: https://github.com/nodejs/node/pull/15633 Refs: https://github.com/expressjs/express/tree/master/test Refs: https://github.com/jshttp/on-finished/blob/master/test/test.js Refs: https://github.com/pillarjs/finalhandler/blob/master/test/test.js PR-URL: https://github.com/nodejs/node/pull/15702 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
79 lines
2.1 KiB
JavaScript
79 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
// we use the lower-level API here
|
|
server.on('stream', common.mustCall((stream) => {
|
|
stream.respond({ ':status': 200 });
|
|
|
|
// The first pushStream will complete as normal
|
|
stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${server.address().port}`,
|
|
}, common.mustCall((pushedStream) => {
|
|
pushedStream.respond({ ':status': 200 });
|
|
pushedStream.end();
|
|
pushedStream.on('aborted', common.mustNotCall());
|
|
}));
|
|
|
|
// The second pushStream will be aborted because the client
|
|
// will reject it due to the maxReservedRemoteStreams option
|
|
// being set to only 1
|
|
stream.pushStream({
|
|
':scheme': 'http',
|
|
':path': '/foobar',
|
|
':authority': `localhost:${server.address().port}`,
|
|
}, common.mustCall((pushedStream) => {
|
|
pushedStream.respond({ ':status': 200 });
|
|
pushedStream.on('aborted', common.mustCall());
|
|
pushedStream.on('error', common.mustNotCall());
|
|
pushedStream.on('streamClosed',
|
|
common.mustCall((code) => assert.strictEqual(code, 8)));
|
|
}));
|
|
|
|
stream.end('hello world');
|
|
}));
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(() => {
|
|
|
|
const options = {
|
|
maxReservedRemoteStreams: 1
|
|
};
|
|
|
|
const client = h2.connect(`http://localhost:${server.address().port}`,
|
|
options);
|
|
|
|
let remaining = 2;
|
|
function maybeClose() {
|
|
if (--remaining === 0) {
|
|
server.close();
|
|
client.destroy();
|
|
}
|
|
}
|
|
|
|
const req = client.request({ ':path': '/' });
|
|
|
|
// Because maxReservedRemoteStream is 1, the stream event
|
|
// must only be emitted once, even tho the server sends
|
|
// two push streams.
|
|
client.on('stream', common.mustCall((stream) => {
|
|
stream.resume();
|
|
stream.on('end', common.mustCall());
|
|
stream.on('streamClosed', common.mustCall(maybeClose));
|
|
}));
|
|
|
|
req.on('response', common.mustCall());
|
|
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('streamClosed', common.mustCall(maybeClose));
|
|
}));
|