mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00
2da7d9b820
Extensive re-work of http1 compatibility layer based on tests in express, on-finished and finalhandler. Fix handling of HEAD method to match http1. Adjust write, end, etc. to call writeHead as in http1 and as expected by user-land modules. Add socket proxy that instead uses the Http2Stream for the vast majority of socket interactions. Add and change tests to closer represent http1 behaviour. Refs: https://github.com/nodejs/node/pull/15633 Refs: https://github.com/expressjs/express/tree/master/test Refs: https://github.com/jshttp/on-finished/blob/master/test/test.js Refs: https://github.com/pillarjs/finalhandler/blob/master/test/test.js PR-URL: https://github.com/nodejs/node/pull/15702 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
53 lines
1.5 KiB
JavaScript
53 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Http2ServerResponse.writeHead should override previous headers
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
response.setHeader('foo-bar', 'def456');
|
|
response.writeHead(418, { 'foo-bar': 'abc123' }); // Override
|
|
|
|
common.expectsError(() => { response.writeHead(300); }, {
|
|
code: 'ERR_HTTP2_HEADERS_SENT'
|
|
});
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
server.close();
|
|
process.nextTick(common.mustCall(() => {
|
|
common.expectsError(() => { response.writeHead(300); }, {
|
|
code: 'ERR_HTTP2_STREAM_CLOSED'
|
|
});
|
|
}));
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('response', common.mustCall(function(headers) {
|
|
assert.strictEqual(headers['foo-bar'], 'abc123');
|
|
assert.strictEqual(headers[':status'], 418);
|
|
}, 1));
|
|
request.on('end', common.mustCall(function() {
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|