mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00
2da7d9b820
Extensive re-work of http1 compatibility layer based on tests in express, on-finished and finalhandler. Fix handling of HEAD method to match http1. Adjust write, end, etc. to call writeHead as in http1 and as expected by user-land modules. Add socket proxy that instead uses the Http2Stream for the vast majority of socket interactions. Add and change tests to closer represent http1 behaviour. Refs: https://github.com/nodejs/node/pull/15633 Refs: https://github.com/expressjs/express/tree/master/test Refs: https://github.com/jshttp/on-finished/blob/master/test/test.js Refs: https://github.com/pillarjs/finalhandler/blob/master/test/test.js PR-URL: https://github.com/nodejs/node/pull/15702 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
88 lines
2.5 KiB
JavaScript
88 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Http2ServerRequest should have header helpers
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
const expected = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
'foo-bar': 'abc123'
|
|
};
|
|
|
|
assert.strictEqual(request.path, undefined);
|
|
assert.strictEqual(request.method, expected[':method']);
|
|
assert.strictEqual(request.scheme, expected[':scheme']);
|
|
assert.strictEqual(request.url, expected[':path']);
|
|
assert.strictEqual(request.authority, expected[':authority']);
|
|
|
|
const headers = request.headers;
|
|
for (const [name, value] of Object.entries(expected)) {
|
|
assert.strictEqual(headers[name], value);
|
|
}
|
|
|
|
const rawHeaders = request.rawHeaders;
|
|
for (const [name, value] of Object.entries(expected)) {
|
|
const position = rawHeaders.indexOf(name);
|
|
assert.notStrictEqual(position, -1);
|
|
assert.strictEqual(rawHeaders[position + 1], value);
|
|
}
|
|
|
|
request.url = '/one';
|
|
assert.strictEqual(request.url, '/one');
|
|
|
|
// third-party plugins for packages like express use query params to
|
|
// change the request method
|
|
request.method = 'POST';
|
|
assert.strictEqual(request.method, 'POST');
|
|
common.expectsError(
|
|
() => request.method = ' ',
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "method" argument must be of type string'
|
|
}
|
|
);
|
|
common.expectsError(
|
|
() => request.method = true,
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError,
|
|
message: 'The "method" argument must be of type string'
|
|
}
|
|
);
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
server.close();
|
|
}));
|
|
response.end();
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/foobar',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`,
|
|
'foo-bar': 'abc123'
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('end', common.mustCall(function() {
|
|
client.destroy();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|