mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 02:06:12 +00:00
2043944a4c
Makes `Connection: keep-alive` behave correctly when making client connections to UNIX domain sockets. Prior to this, connections would never be re-used, but the keep-alive would cause the connections to stick around until they time out. This would lead to an eventual EMFILE error due to all the connections staying open. This was due to http.Agent not properly supporting UNIX domain sockets. PR-URL: https://github.com/nodejs/node/pull/13214 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
49 lines
948 B
JavaScript
49 lines
948 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
const path = require('path');
|
|
|
|
const agent = new http.Agent();
|
|
|
|
// default to localhost
|
|
assert.strictEqual(
|
|
agent.getName({
|
|
port: 80,
|
|
localAddress: '192.168.1.1'
|
|
}),
|
|
'localhost:80:192.168.1.1'
|
|
);
|
|
|
|
// empty
|
|
assert.strictEqual(
|
|
agent.getName({}),
|
|
'localhost::'
|
|
);
|
|
|
|
// pass all arguments
|
|
assert.strictEqual(
|
|
agent.getName({
|
|
host: '0.0.0.0',
|
|
port: 80,
|
|
localAddress: '192.168.1.1'
|
|
}),
|
|
'0.0.0.0:80:192.168.1.1'
|
|
);
|
|
|
|
// unix socket
|
|
const socketPath = path.join(common.tmpDir, 'foo', 'bar');
|
|
assert.strictEqual(
|
|
agent.getName({
|
|
socketPath
|
|
}),
|
|
`localhost:::${socketPath}`
|
|
);
|
|
|
|
for (const family of [0, null, undefined, 'bogus'])
|
|
assert.strictEqual(agent.getName({ family }), 'localhost::');
|
|
|
|
for (const family of [4, 6])
|
|
assert.strictEqual(agent.getName({ family }), `localhost:::${family}`);
|