mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 20:25:27 +00:00
2249234fee
Many callbacks appear to be invoked with `this` set to `undefined` including `fs.stat()`, `fs.lstat()`, and `fs.fstat()`. However, some such as `fs.open()` and `fs.mkdtemp()` invoke their callbacks with `this` set to `null`. Change to `undefined`. PR-URL: https://github.com/nodejs/node/pull/14645 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
36 lines
1.2 KiB
JavaScript
36 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
|
|
common.refreshTmpDir();
|
|
|
|
const tmpFolder = fs.mkdtempSync(path.join(common.tmpDir, 'foo.'));
|
|
|
|
assert.strictEqual(path.basename(tmpFolder).length, 'foo.XXXXXX'.length);
|
|
assert(common.fileExists(tmpFolder));
|
|
|
|
const utf8 = fs.mkdtempSync(path.join(common.tmpDir, '\u0222abc.'));
|
|
assert.strictEqual(Buffer.byteLength(path.basename(utf8)),
|
|
Buffer.byteLength('\u0222abc.XXXXXX'));
|
|
assert(common.fileExists(utf8));
|
|
|
|
function handler(err, folder) {
|
|
assert.ifError(err);
|
|
assert(common.fileExists(folder));
|
|
assert.strictEqual(this, undefined);
|
|
}
|
|
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), common.mustCall(handler));
|
|
|
|
// Same test as above, but making sure that passing an options object doesn't
|
|
// affect the way the callback function is handled.
|
|
fs.mkdtemp(path.join(common.tmpDir, 'bar.'), {}, common.mustCall(handler));
|
|
|
|
// Making sure that not passing a callback doesn't crash, as a default function
|
|
// is passed internally.
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-')));
|
|
assert.doesNotThrow(() => fs.mkdtemp(path.join(common.tmpDir, 'bar-'), {}));
|