mirror of
https://github.com/nodejs/node.git
synced 2025-05-03 02:06:12 +00:00
f4899ac4c0
Currently if the buffer size exceeds the maximum int size the following
error will be thrown:
dgram.js:180
throw new errors.Error('ERR_SOCKET_BUFFER_SIZE', e);
^
Error [ERR_SOCKET_BUFFER_SIZE]: Could not get or set buffer size: Error:
Unknown system error 22: Unknown system error 22, uv_recv_buffer_size
at bufferSize (dgram.js:180:11)
It looks like perhaps UV_EINVAL was intended to give the following error
message instead:
dgram.js:180
throw new errors.Error('ERR_SOCKET_BUFFER_SIZE', e);
^
Error [ERR_SOCKET_BUFFER_SIZE]: Could not get or set buffer size: Error:
EINVAL: invalid argument, uv_recv_buffer_size
at bufferSize (dgram.js:180:11)
This commit changes EINVAL to use UV_EINVAL.
PR-URL: https://github.com/nodejs/node/pull/15444
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
96 lines
2.5 KiB
JavaScript
96 lines
2.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
|
|
{
|
|
// Should throw error if the socket is never bound.
|
|
const errorObj = {
|
|
code: 'ERR_SOCKET_BUFFER_SIZE',
|
|
type: Error,
|
|
message: /^Could not get or set buffer size:.*$/
|
|
};
|
|
|
|
const socket = dgram.createSocket('udp4');
|
|
|
|
assert.throws(() => {
|
|
socket.setRecvBufferSize(8192);
|
|
}, common.expectsError(errorObj));
|
|
|
|
assert.throws(() => {
|
|
socket.setSendBufferSize(8192);
|
|
}, common.expectsError(errorObj));
|
|
|
|
assert.throws(() => {
|
|
socket.getRecvBufferSize();
|
|
}, common.expectsError(errorObj));
|
|
|
|
assert.throws(() => {
|
|
socket.getSendBufferSize();
|
|
}, common.expectsError(errorObj));
|
|
}
|
|
|
|
{
|
|
// Should throw error if invalid buffer size is specified
|
|
const errorObj = {
|
|
code: 'ERR_SOCKET_BAD_BUFFER_SIZE',
|
|
type: TypeError,
|
|
message: /^Buffer size must be a positive integer$/
|
|
};
|
|
|
|
const badBufferSizes = [-1, Infinity, 'Doh!'];
|
|
|
|
const socket = dgram.createSocket('udp4');
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
badBufferSizes.forEach((badBufferSize) => {
|
|
assert.throws(() => {
|
|
socket.setRecvBufferSize(badBufferSize);
|
|
}, common.expectsError(errorObj));
|
|
|
|
assert.throws(() => {
|
|
socket.setSendBufferSize(badBufferSize);
|
|
}, common.expectsError(errorObj));
|
|
});
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Can set and get buffer sizes after binding the socket.
|
|
const socket = dgram.createSocket('udp4');
|
|
|
|
socket.bind(common.mustCall(() => {
|
|
socket.setRecvBufferSize(10000);
|
|
socket.setSendBufferSize(10000);
|
|
|
|
// note: linux will double the buffer size
|
|
const expectedBufferSize = common.isLinux ? 20000 : 10000;
|
|
assert.strictEqual(socket.getRecvBufferSize(), expectedBufferSize);
|
|
assert.strictEqual(socket.getSendBufferSize(), expectedBufferSize);
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
function checkBufferSizeError(type, size) {
|
|
const errorObj = {
|
|
code: 'ERR_SOCKET_BUFFER_SIZE',
|
|
type: Error,
|
|
message: 'Could not get or set buffer size: Error: EINVAL: ' +
|
|
`invalid argument, uv_${type}_buffer_size`
|
|
};
|
|
const functionName = `set${type.charAt(0).toUpperCase()}${type.slice(1)}` +
|
|
'BufferSize';
|
|
const socket = dgram.createSocket('udp4');
|
|
socket.bind(common.mustCall(() => {
|
|
assert.throws(() => {
|
|
socket[functionName](size);
|
|
}, common.expectsError(errorObj));
|
|
socket.close();
|
|
}));
|
|
}
|
|
|
|
checkBufferSizeError('recv', 2147483648);
|
|
checkBufferSizeError('send', 2147483648);
|