mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00
76340e3f10
* Remove needless RegExp flag In fixed case, `/g` flag is needless in the boolean context. * Remove needless RegExp capturing Use non-capturing grouping or remove capturing completely when: * capturing is useless per se, e.g. in test() check; * captured groups are not used afterward at all; * some of the later captured groups are not used afterward. * Use test, not match/exec in boolean context match() and exec() return a complicated object, unneeded in a boolean context. * Do not needlessly repeat RegExp creation This commit takes RegExp creation out of cycles and other repetitions. As long as the RegExp does not use /g flag and match indices, we are safe here. In tests, this fix hardly gives a significant performance gain, but it increases clarity and maintainability, reassuring some RegExps to be identical. RegExp in functions are not taken out of their functions: while these functions are called many times and their RegExps are recreated with each call, the performance gain in test cases does not seem to be worth decreasing function self-dependency. PR-URL: https://github.com/nodejs/node/pull/13770 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
24 lines
547 B
JavaScript
24 lines
547 B
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// lib/buffer.js defines Buffer.prototype.inspect() to override how buffers are
|
|
// presented by util.inspect().
|
|
|
|
const assert = require('assert');
|
|
const util = require('util');
|
|
|
|
{
|
|
const buf = Buffer.from('fhqwhgads');
|
|
assert.strictEqual(util.inspect(buf), '<Buffer 66 68 71 77 68 67 61 64 73>');
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.from('');
|
|
assert.strictEqual(util.inspect(buf), '<Buffer >');
|
|
}
|
|
|
|
{
|
|
const buf = Buffer.from('x'.repeat(51));
|
|
assert.ok(/^<Buffer (?:78 ){50}\.\.\. >$/.test(util.inspect(buf)));
|
|
}
|