mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 17:01:08 +00:00
af1a551965
Until now, the async_hooks PromiseHook did not register the Promise’s async id and trigger id on the id stack, so inside the `.then()` handler those ids would be invalid. To fix this, add push and pop calls to its `before` and `after` parts, respectively. Some care needs to be taken for the cases that the Promise hook is being disabled or enabled during the execution of a Promise handler; in the former case, actually removing the hook is delayed by adding another task to the microtask queue, in the latter case popping the id off the async id stack is skipped if the ids don’t match. Fixes: https://github.com/nodejs/node/issues/13583 PR-URL: https://github.com/nodejs/node/pull/13585 Reviewed-By: Trevor Norris <trevnorris@gmail.com>
33 lines
975 B
JavaScript
33 lines
975 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
|
|
common.crashOnUnhandledRejection();
|
|
|
|
const promiseAsyncIds = [];
|
|
|
|
async_hooks.createHook({
|
|
init: common.mustCallAtLeast((id, type, triggerId) => {
|
|
if (type === 'PROMISE') {
|
|
// Check that the last known Promise is triggering the creation of
|
|
// this one.
|
|
assert.strictEqual(promiseAsyncIds[promiseAsyncIds.length - 1] || 1,
|
|
triggerId);
|
|
promiseAsyncIds.push(id);
|
|
}
|
|
}, 3),
|
|
before: common.mustCall((id) => {
|
|
assert.strictEqual(id, promiseAsyncIds[1]);
|
|
}),
|
|
after: common.mustCall((id) => {
|
|
assert.strictEqual(id, promiseAsyncIds[1]);
|
|
})
|
|
}).enable();
|
|
|
|
Promise.resolve(42).then(common.mustCall(() => {
|
|
assert.strictEqual(async_hooks.executionAsyncId(), promiseAsyncIds[1]);
|
|
assert.strictEqual(async_hooks.triggerAsyncId(), promiseAsyncIds[0]);
|
|
Promise.resolve(10);
|
|
}));
|