mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 06:53:52 +00:00
ed3b057e9f
Currently, if util.format() is called with a string as its first argument, and a Symbol as one of the subsequent arguments, an exception is thrown due to an attempted implicit string conversion. This commit causes Symbols to be explicitly converted. Fixes: https://github.com/iojs/io.js/issues/927 PR-URL: https://github.com/iojs/io.js/pull/931 Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
65 lines
2.3 KiB
JavaScript
65 lines
2.3 KiB
JavaScript
var common = require('../common');
|
|
var assert = require('assert');
|
|
var util = require('util');
|
|
var symbol = Symbol('foo');
|
|
|
|
assert.equal(util.format(), '');
|
|
assert.equal(util.format(''), '');
|
|
assert.equal(util.format([]), '[]');
|
|
assert.equal(util.format({}), '{}');
|
|
assert.equal(util.format(null), 'null');
|
|
assert.equal(util.format(true), 'true');
|
|
assert.equal(util.format(false), 'false');
|
|
assert.equal(util.format('test'), 'test');
|
|
|
|
// CHECKME this is for console.log() compatibility - but is it *right*?
|
|
assert.equal(util.format('foo', 'bar', 'baz'), 'foo bar baz');
|
|
|
|
// ES6 Symbol handling
|
|
assert.equal(util.format(symbol), 'Symbol(foo)');
|
|
assert.equal(util.format('foo', symbol), 'foo Symbol(foo)');
|
|
assert.equal(util.format('%s', symbol), 'Symbol(foo)');
|
|
assert.equal(util.format('%j', symbol), 'undefined');
|
|
assert.throws(function() {
|
|
util.format('%d', symbol);
|
|
}, TypeError);
|
|
|
|
assert.equal(util.format('%d', 42.0), '42');
|
|
assert.equal(util.format('%d', 42), '42');
|
|
assert.equal(util.format('%s', 42), '42');
|
|
assert.equal(util.format('%j', 42), '42');
|
|
|
|
assert.equal(util.format('%d', '42.0'), '42');
|
|
assert.equal(util.format('%d', '42'), '42');
|
|
assert.equal(util.format('%s', '42'), '42');
|
|
assert.equal(util.format('%j', '42'), '"42"');
|
|
|
|
assert.equal(util.format('%%s%s', 'foo'), '%sfoo');
|
|
|
|
assert.equal(util.format('%s'), '%s');
|
|
assert.equal(util.format('%s', undefined), 'undefined');
|
|
assert.equal(util.format('%s', 'foo'), 'foo');
|
|
assert.equal(util.format('%s:%s'), '%s:%s');
|
|
assert.equal(util.format('%s:%s', undefined), 'undefined:%s');
|
|
assert.equal(util.format('%s:%s', 'foo'), 'foo:%s');
|
|
assert.equal(util.format('%s:%s', 'foo', 'bar'), 'foo:bar');
|
|
assert.equal(util.format('%s:%s', 'foo', 'bar', 'baz'), 'foo:bar baz');
|
|
assert.equal(util.format('%%%s%%', 'hi'), '%hi%');
|
|
assert.equal(util.format('%%%s%%%%', 'hi'), '%hi%%');
|
|
|
|
(function() {
|
|
var o = {};
|
|
o.o = o;
|
|
assert.equal(util.format('%j', o), '[Circular]');
|
|
})();
|
|
|
|
// Errors
|
|
assert.equal(util.format(new Error('foo')), '[Error: foo]');
|
|
function CustomError(msg) {
|
|
Error.call(this);
|
|
Object.defineProperty(this, 'message', { value: msg, enumerable: false });
|
|
Object.defineProperty(this, 'name', { value: 'CustomError', enumerable: false });
|
|
}
|
|
util.inherits(CustomError, Error);
|
|
assert.equal(util.format(new CustomError('bar')), '[CustomError: bar]');
|