mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 23:56:58 +00:00
eb9748d222
This adds missing async_hooks destroy calls for sockets (in _http_agent.js) and HTTP parsers. We need to emit a destroy in AsyncWrap#AsyncReset before assigning a new async_id when the instance has already been in use and is being recycled, because in that case, we have already emitted an init for the "old" async_id. This also removes a duplicated init call for HTTP parser: Each time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. PR-URL: https://github.com/nodejs/node/pull/23272 Fixes: https://github.com/nodejs/node/issues/19859 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
54 lines
1.4 KiB
JavaScript
54 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasIPv6)
|
|
common.skip('IPv6 support required');
|
|
|
|
const initHooks = require('./init-hooks');
|
|
const verifyGraph = require('./verify-graph');
|
|
const http = require('http');
|
|
|
|
const hooks = initHooks();
|
|
hooks.enable();
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
res.end();
|
|
this.close(common.mustCall());
|
|
}));
|
|
server.listen(0, common.mustCall(function() {
|
|
http.get({
|
|
host: '::1',
|
|
family: 6,
|
|
port: server.address().port
|
|
}, common.mustCall());
|
|
}));
|
|
|
|
process.on('exit', function() {
|
|
hooks.disable();
|
|
|
|
verifyGraph(
|
|
hooks,
|
|
[ { type: 'TCPSERVERWRAP',
|
|
id: 'tcpserver:1',
|
|
triggerAsyncId: null },
|
|
{ type: 'TCPWRAP', id: 'tcp:1', triggerAsyncId: 'tcpserver:1' },
|
|
{ type: 'TCPCONNECTWRAP',
|
|
id: 'tcpconnect:1',
|
|
triggerAsyncId: 'tcp:1' },
|
|
{ type: 'HTTPPARSER',
|
|
id: 'httpparser:1',
|
|
triggerAsyncId: 'tcpserver:1' },
|
|
{ type: 'TCPWRAP', id: 'tcp:2', triggerAsyncId: 'tcpserver:1' },
|
|
{ type: 'Timeout', id: 'timeout:1', triggerAsyncId: 'tcp:2' },
|
|
{ type: 'HTTPPARSER',
|
|
id: 'httpparser:2',
|
|
triggerAsyncId: 'tcp:2' },
|
|
{ type: 'Timeout',
|
|
id: 'timeout:2',
|
|
triggerAsyncId: 'httpparser:2' },
|
|
{ type: 'SHUTDOWNWRAP',
|
|
id: 'shutdown:1',
|
|
triggerAsyncId: 'tcp:2' } ]
|
|
);
|
|
});
|