mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 19:17:56 +00:00

This adds missing async_hooks destroy calls for sockets (in _http_agent.js) and HTTP parsers. We need to emit a destroy in AsyncWrap#AsyncReset before assigning a new async_id when the instance has already been in use and is being recycled, because in that case, we have already emitted an init for the "old" async_id. This also removes a duplicated init call for HTTP parser: Each time a new parser was created, AsyncReset was being called via the C++ Parser class constructor (super constructor AsyncWrap) and also via Parser::Reinitialize. PR-URL: https://github.com/nodejs/node/pull/23272 Fixes: https://github.com/nodejs/node/issues/19859 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
55 lines
1.4 KiB
JavaScript
55 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const bench = common.createBenchmark(main, {
|
|
len: [4, 8, 16, 32],
|
|
n: [1e5]
|
|
}, {
|
|
flags: ['--expose-internals', '--no-warnings']
|
|
});
|
|
|
|
function main({ len, n }) {
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const { HTTPParser } = internalBinding('http_parser');
|
|
const REQUEST = HTTPParser.REQUEST;
|
|
const kOnHeaders = HTTPParser.kOnHeaders | 0;
|
|
const kOnHeadersComplete = HTTPParser.kOnHeadersComplete | 0;
|
|
const kOnBody = HTTPParser.kOnBody | 0;
|
|
const kOnMessageComplete = HTTPParser.kOnMessageComplete | 0;
|
|
const CRLF = '\r\n';
|
|
|
|
function processHeader(header, n) {
|
|
const parser = newParser(REQUEST);
|
|
|
|
bench.start();
|
|
for (var i = 0; i < n; i++) {
|
|
parser.execute(header, 0, header.length);
|
|
parser.reinitialize(REQUEST, i > 0);
|
|
}
|
|
bench.end(n);
|
|
}
|
|
|
|
function newParser(type) {
|
|
const parser = new HTTPParser(type);
|
|
|
|
parser.headers = [];
|
|
|
|
parser[kOnHeaders] = function() { };
|
|
parser[kOnHeadersComplete] = function() { };
|
|
parser[kOnBody] = function() { };
|
|
parser[kOnMessageComplete] = function() { };
|
|
|
|
return parser;
|
|
}
|
|
|
|
let header = `GET /hello HTTP/1.1${CRLF}Content-Type: text/plain${CRLF}`;
|
|
|
|
for (var i = 0; i < len; i++) {
|
|
header += `X-Filler${i}: ${Math.random().toString(36).substr(2)}${CRLF}`;
|
|
}
|
|
header += CRLF;
|
|
|
|
processHeader(Buffer.from(header), n);
|
|
}
|