mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 16:46:56 +00:00

Set the default maxBuffer size to 204,800 bytes for execSync, execFileSync, and spawnSync. APIs that return the child output as a string should have non-infinite defaults for maxBuffer sizes to avoid out-of-memory error conditions. A non-infinite default used to be the documented behaviour for all relevant APIs, but the implemented behaviour for execSync, execFileSync and spawnSync was to have no maxBuffer limits. PR-URL: https://github.com/nodejs/node/pull/23027 Refs: https://github.com/nodejs/node/pull/22894 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
60 lines
1.5 KiB
JavaScript
60 lines
1.5 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
// This test checks that the maxBuffer option for child_process.spawnSync()
|
|
// works as expected.
|
|
|
|
const assert = require('assert');
|
|
const { execSync } = require('child_process');
|
|
const msgOut = 'this is stdout';
|
|
const msgOutBuf = Buffer.from(`${msgOut}\n`);
|
|
|
|
const args = [
|
|
'-e',
|
|
`"console.log('${msgOut}')";`
|
|
];
|
|
|
|
// Verify that an error is returned if maxBuffer is surpassed.
|
|
{
|
|
assert.throws(() => {
|
|
execSync(`"${process.execPath}" ${args.join(' ')}`, { maxBuffer: 1 });
|
|
}, (e) => {
|
|
assert.ok(e, 'maxBuffer should error');
|
|
assert.strictEqual(e.errno, 'ENOBUFS');
|
|
// We can have buffers larger than maxBuffer because underneath we alloc 64k
|
|
// that matches our read sizes.
|
|
assert.deepStrictEqual(e.stdout, msgOutBuf);
|
|
return true;
|
|
});
|
|
}
|
|
|
|
// Verify that a maxBuffer size of Infinity works.
|
|
{
|
|
const ret = execSync(
|
|
`"${process.execPath}" ${args.join(' ')}`,
|
|
{ maxBuffer: Infinity }
|
|
);
|
|
|
|
assert.deepStrictEqual(ret, msgOutBuf);
|
|
}
|
|
|
|
// Default maxBuffer size is 200 * 1024.
|
|
{
|
|
assert.throws(() => {
|
|
execSync(`"${process.execPath}" -e "console.log('a'.repeat(200 * 1024))"`);
|
|
}, (e) => {
|
|
assert.ok(e, 'maxBuffer should error');
|
|
assert.strictEqual(e.errno, 'ENOBUFS');
|
|
return true;
|
|
});
|
|
}
|
|
|
|
// Default maxBuffer size is 200 * 1024.
|
|
{
|
|
const ret = execSync(
|
|
`"${process.execPath}" -e "console.log('a'.repeat(200 * 1024 - 1))"`
|
|
);
|
|
|
|
assert.deepStrictEqual(ret.toString().trim(), 'a'.repeat(200 * 1024 - 1));
|
|
}
|