mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
ea6a4576ae
Under high load 2 types of issues arise with this test. * filesystem calls gets queued even when the 'sync' is used which leads to async_hooks being called with the events of tmpdir clean or initial file write after clean. This is solved by counting all 'change' calls while making sure there is no dependency of StatWatcher's on one another and the expected changes are waited for. * some events are getting lost with the current clean->write->write_and_watch strategy. Specifically I observed the file size going from 0 to 5 entirely skipping 3 even though the write call was there (this happened reliably on -j128). So I've changed the strategy to avoid additional write considering this still tests the hooks correctly. This may indicate some sort of bug in async_hooks though I'm not sure. Closes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/30362 Fixes: https://github.com/nodejs/node/issues/21425 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
22 lines
418 B
Plaintext
22 lines
418 B
Plaintext
prefix async-hooks
|
|
|
|
# To mark a test as flaky, list the test name in the appropriate section
|
|
# below, without ".js", followed by ": PASS,FLAKY". Example:
|
|
# sample-test : PASS,FLAKY
|
|
|
|
[true] # This section applies to all platforms
|
|
|
|
[$system==win32]
|
|
|
|
[$system==linux]
|
|
|
|
[$system==macos]
|
|
|
|
[$arch==arm || $arch==arm64]
|
|
|
|
[$system==solaris] # Also applies to SmartOS
|
|
|
|
[$system==freebsd]
|
|
|
|
[$system==aix]
|