mirror of
https://github.com/nodejs/node.git
synced 2025-05-18 17:26:24 +00:00
d91e10b3bd
PR-URL: https://github.com/nodejs/io.js/pull/2072 Reviewed-By: Yosuke Furukawa <yosuke.furukawa@gmail.com> Reviewed-by: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alex Kocharin <alex@kocharin.ru>
30 lines
952 B
JavaScript
30 lines
952 B
JavaScript
/**
|
|
* @fileoverview Rule to flag comparison where left part is the same as the right
|
|
* part.
|
|
* @author Ilya Volodin
|
|
*/
|
|
|
|
"use strict";
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
module.exports = function(context) {
|
|
|
|
return {
|
|
|
|
"BinaryExpression": function(node) {
|
|
var operators = ["===", "==", "!==", "!=", ">", "<", ">=", "<="];
|
|
if (operators.indexOf(node.operator) > -1 &&
|
|
(node.left.type === "Identifier" && node.right.type === "Identifier" && node.left.name === node.right.name ||
|
|
node.left.type === "Literal" && node.right.type === "Literal" && node.left.value === node.right.value)) {
|
|
context.report(node, "Comparing to itself is potentially pointless.");
|
|
}
|
|
}
|
|
};
|
|
|
|
};
|
|
|
|
module.exports.schema = [];
|