mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00

This fixes the importKey operation when importing a JWK for the ECDH algorithm. As per the Web Crypto API specification the JWK `alg` property is not checked (as opposed to ECDSA). PR-URL: https://github.com/nodejs/node/pull/35855 Fixes: https://github.com/nodejs/node/issues/35812 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
305 lines
7.7 KiB
JavaScript
305 lines
7.7 KiB
JavaScript
'use strict';
|
|
|
|
const {
|
|
ObjectKeys,
|
|
Promise,
|
|
SafeSet,
|
|
} = primordials;
|
|
|
|
const {
|
|
ECKeyExportJob,
|
|
KeyObjectHandle,
|
|
SignJob,
|
|
kCryptoJobAsync,
|
|
kKeyTypePrivate,
|
|
kSignJobModeSign,
|
|
kSignJobModeVerify,
|
|
} = internalBinding('crypto');
|
|
|
|
const {
|
|
validateOneOf,
|
|
validateString,
|
|
} = require('internal/validators');
|
|
|
|
const {
|
|
codes: {
|
|
ERR_INVALID_ARG_TYPE,
|
|
ERR_MISSING_OPTION,
|
|
}
|
|
} = require('internal/errors');
|
|
|
|
const {
|
|
getArrayBufferOrView,
|
|
getUsagesUnion,
|
|
hasAnyNotIn,
|
|
jobPromise,
|
|
lazyDOMException,
|
|
normalizeHashName,
|
|
validateKeyOps,
|
|
kHandle,
|
|
kKeyObject,
|
|
kNamedCurveAliases,
|
|
} = require('internal/crypto/util');
|
|
|
|
const {
|
|
generateKeyPair,
|
|
} = require('internal/crypto/keygen');
|
|
|
|
const {
|
|
InternalCryptoKey,
|
|
PrivateKeyObject,
|
|
PublicKeyObject,
|
|
createPrivateKey,
|
|
createPublicKey,
|
|
isKeyObject,
|
|
} = require('internal/crypto/keys');
|
|
|
|
function verifyAcceptableEcKeyUse(name, type, usages) {
|
|
let checkSet;
|
|
switch (name) {
|
|
case 'ECDH':
|
|
checkSet = ['deriveKey', 'deriveBits'];
|
|
break;
|
|
case 'ECDSA':
|
|
switch (type) {
|
|
case 'private':
|
|
checkSet = ['sign'];
|
|
break;
|
|
case 'public':
|
|
checkSet = ['verify'];
|
|
break;
|
|
}
|
|
}
|
|
if (hasAnyNotIn(usages, ...checkSet)) {
|
|
throw lazyDOMException(
|
|
`Unsupported key usage for a ${name} key`,
|
|
'SyntaxError');
|
|
}
|
|
}
|
|
|
|
function createECPublicKeyRaw(namedCurve, keyData) {
|
|
const handle = new KeyObjectHandle();
|
|
keyData = getArrayBufferOrView(keyData, 'keyData');
|
|
if (handle.initECRaw(kNamedCurveAliases[namedCurve], keyData))
|
|
return new PublicKeyObject(handle);
|
|
}
|
|
|
|
async function ecGenerateKey(algorithm, extractable, keyUsages) {
|
|
const { name, namedCurve } = algorithm;
|
|
validateString(namedCurve, 'algorithm.namedCurve');
|
|
validateOneOf(
|
|
namedCurve,
|
|
'algorithm.namedCurve',
|
|
ObjectKeys(kNamedCurveAliases));
|
|
|
|
const usageSet = new SafeSet(keyUsages);
|
|
switch (name) {
|
|
case 'ECDSA':
|
|
if (hasAnyNotIn(usageSet, 'sign', 'verify')) {
|
|
throw lazyDOMException(
|
|
'Unsupported key usage for an ECDSA key',
|
|
'SyntaxError');
|
|
}
|
|
break;
|
|
case 'ECDH':
|
|
if (hasAnyNotIn(usageSet, 'deriveKey', 'deriveBits')) {
|
|
throw lazyDOMException(
|
|
'Unsupported key usage for an ECDH key',
|
|
'SyntaxError');
|
|
}
|
|
}
|
|
return new Promise((resolve, reject) => {
|
|
generateKeyPair('ec', { namedCurve }, (err, pubKey, privKey) => {
|
|
if (err) {
|
|
return reject(lazyDOMException(
|
|
'The operation failed for an operation-specific reason',
|
|
'OperationError'));
|
|
}
|
|
|
|
const algorithm = { name, namedCurve };
|
|
|
|
let publicUsages;
|
|
let privateUsages;
|
|
switch (name) {
|
|
case 'ECDSA':
|
|
publicUsages = getUsagesUnion(usageSet, 'verify');
|
|
privateUsages = getUsagesUnion(usageSet, 'sign');
|
|
break;
|
|
case 'ECDH':
|
|
publicUsages = [];
|
|
privateUsages = getUsagesUnion(usageSet, 'deriveKey', 'deriveBits');
|
|
break;
|
|
}
|
|
|
|
const publicKey =
|
|
new InternalCryptoKey(
|
|
pubKey,
|
|
algorithm,
|
|
publicUsages,
|
|
true);
|
|
|
|
const privateKey =
|
|
new InternalCryptoKey(
|
|
privKey,
|
|
algorithm,
|
|
privateUsages,
|
|
extractable);
|
|
|
|
resolve({ publicKey, privateKey });
|
|
});
|
|
});
|
|
}
|
|
|
|
function ecExportKey(key, format) {
|
|
return jobPromise(new ECKeyExportJob(
|
|
kCryptoJobAsync,
|
|
format,
|
|
key[kKeyObject][kHandle]));
|
|
}
|
|
|
|
async function ecImportKey(
|
|
format,
|
|
keyData,
|
|
algorithm,
|
|
extractable,
|
|
keyUsages) {
|
|
|
|
const { name, namedCurve } = algorithm;
|
|
validateString(namedCurve, 'algorithm.namedCurve');
|
|
validateOneOf(
|
|
namedCurve,
|
|
'algorithm.namedCurve',
|
|
ObjectKeys(kNamedCurveAliases));
|
|
|
|
let keyObject;
|
|
const usagesSet = new SafeSet(keyUsages);
|
|
switch (format) {
|
|
case 'node.keyObject': {
|
|
if (!isKeyObject(keyData))
|
|
throw new ERR_INVALID_ARG_TYPE('keyData', 'KeyObject', keyData);
|
|
if (keyData.type === 'secret')
|
|
throw lazyDOMException('Invalid key type', 'InvalidAccessException');
|
|
verifyAcceptableEcKeyUse(name, keyData.type, usagesSet);
|
|
keyObject = keyData;
|
|
break;
|
|
}
|
|
case 'spki': {
|
|
verifyAcceptableEcKeyUse(name, 'public', usagesSet);
|
|
keyObject = createPublicKey({
|
|
key: keyData,
|
|
format: 'der',
|
|
type: 'spki'
|
|
});
|
|
break;
|
|
}
|
|
case 'pkcs8': {
|
|
verifyAcceptableEcKeyUse(name, 'private', usagesSet);
|
|
keyObject = createPrivateKey({
|
|
key: keyData,
|
|
format: 'der',
|
|
type: 'pkcs8'
|
|
});
|
|
break;
|
|
}
|
|
case 'jwk': {
|
|
let curve;
|
|
if (keyData == null || typeof keyData !== 'object')
|
|
throw lazyDOMException('Invalid JWK keyData', 'DataError');
|
|
|
|
if (keyData.kty !== 'EC')
|
|
throw lazyDOMException('Invalid key type', 'DataError');
|
|
|
|
if (keyData.d !== undefined) {
|
|
verifyAcceptableEcKeyUse(name, 'private', usagesSet);
|
|
} else {
|
|
verifyAcceptableEcKeyUse(name, 'public', usagesSet);
|
|
}
|
|
|
|
if (usagesSet.size > 0 && keyData.use !== undefined) {
|
|
if (algorithm.name === 'ECDSA' && keyData.use !== 'sig')
|
|
throw lazyDOMException('Invalid use type', 'DataError');
|
|
if (algorithm.name === 'ECDH' && keyData.use !== 'enc')
|
|
throw lazyDOMException('Invalid use type', 'DataError');
|
|
}
|
|
|
|
validateKeyOps(keyData.key_ops, usagesSet);
|
|
|
|
if (keyData.ext !== undefined &&
|
|
keyData.ext === false &&
|
|
extractable === true) {
|
|
throw lazyDOMException('JWK is not extractable', 'DataError');
|
|
}
|
|
|
|
if (algorithm.name === 'ECDSA' && keyData.alg !== undefined) {
|
|
if (typeof keyData.alg !== 'string')
|
|
throw lazyDOMException('Invalid alg', 'DataError');
|
|
switch (keyData.alg) {
|
|
case 'ES256': curve = 'P-256'; break;
|
|
case 'ES384': curve = 'P-384'; break;
|
|
case 'ES512': curve = 'P-521'; break;
|
|
}
|
|
if (curve !== namedCurve)
|
|
throw lazyDOMException('Named curve mismatch', 'DataError');
|
|
}
|
|
|
|
const handle = new KeyObjectHandle();
|
|
const type = handle.initJwk(keyData, namedCurve);
|
|
if (type === undefined)
|
|
throw lazyDOMException('Invalid JWK keyData', 'DataError');
|
|
|
|
keyObject = type === kKeyTypePrivate ?
|
|
new PrivateKeyObject(handle) :
|
|
new PublicKeyObject(handle);
|
|
|
|
break;
|
|
}
|
|
case 'raw': {
|
|
verifyAcceptableEcKeyUse(name, 'public', usagesSet);
|
|
keyObject = createECPublicKeyRaw(namedCurve, keyData);
|
|
if (keyObject === undefined)
|
|
throw lazyDOMException('Unable to import EC key', 'OperationError');
|
|
break;
|
|
}
|
|
}
|
|
|
|
const {
|
|
namedCurve: checkNamedCurve
|
|
} = keyObject[kHandle].keyDetail({});
|
|
if (kNamedCurveAliases[namedCurve] !== checkNamedCurve)
|
|
throw lazyDOMException('Named curve mismatch', 'DataError');
|
|
|
|
return new InternalCryptoKey(
|
|
keyObject,
|
|
{ name, namedCurve },
|
|
keyUsages,
|
|
extractable);
|
|
}
|
|
|
|
function ecdsaSignVerify(key, data, { hash }, signature) {
|
|
if (hash === undefined)
|
|
throw new ERR_MISSING_OPTION('algorithm.hash');
|
|
|
|
const mode = signature === undefined ? kSignJobModeSign : kSignJobModeVerify;
|
|
const type = mode === kSignJobModeSign ? 'private' : 'public';
|
|
|
|
if (key.type !== type)
|
|
throw lazyDOMException(`Key must be a ${type} key`, 'InvalidAccessError');
|
|
|
|
return jobPromise(new SignJob(
|
|
kCryptoJobAsync,
|
|
mode,
|
|
key[kKeyObject][kHandle],
|
|
data,
|
|
normalizeHashName(hash.name),
|
|
undefined, // Salt length, not used with ECDSA
|
|
undefined, // PSS Padding, not used with ECDSA
|
|
signature));
|
|
}
|
|
|
|
module.exports = {
|
|
ecExportKey,
|
|
ecImportKey,
|
|
ecGenerateKey,
|
|
ecdsaSignVerify,
|
|
};
|