mirror of
https://github.com/nodejs/node.git
synced 2025-05-11 01:27:14 +00:00
e48d58b8b2
Using `assert.AssertionError()` without the `new` keyword results
in a non-intuitive error:
```js
> assert.AssertionError({})
TypeError: Cannot assign to read only property 'name' of function 'function ok(value, message) {
if (!value) fail(value, true, message, '==', assert.ok);
}'
at Function.AssertionError (assert.js:45:13)
at repl:1:8
at realRunInThisContextScript (vm.js:22:35)
at sigintHandlersWrap (vm.js:98:12)
at ContextifyScript.Script.runInThisContext (vm.js:24:12)
at REPLServer.defaultEval (repl.js:346:29)
at bound (domain.js:280:14)
at REPLServer.runBound [as eval] (domain.js:293:12)
at REPLServer.onLine (repl.js:545:10)
at emitOne (events.js:101:20)
>
```
The `assert.AssertionError()` can only be used correctly with `new`,
so this converts it into a proper ES6 class that will give an
appropriate error message.
This also associates the appropriate internal/errors code with all
`assert.AssertionError` instances and updates the appropriate test
cases.
PR-URL: https://github.com/nodejs/node/pull/12651
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
43 lines
1.0 KiB
JavaScript
43 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const dgram = require('dgram');
|
|
const UDP = process.binding('udp_wrap').UDP;
|
|
const _createSocketHandle = dgram._createSocketHandle;
|
|
|
|
// Throws if an "existing fd" is passed in.
|
|
assert.throws(() => {
|
|
_createSocketHandle(common.localhostIPv4, 0, 'udp4', 42);
|
|
}, common.expectsError({
|
|
code: 'ERR_ASSERTION',
|
|
message: /^false == true$/
|
|
}));
|
|
|
|
{
|
|
// Create a handle that is not bound.
|
|
const handle = _createSocketHandle(null, null, 'udp4');
|
|
|
|
assert(handle instanceof UDP);
|
|
assert.strictEqual(typeof handle.fd, 'number');
|
|
assert(handle.fd < 0);
|
|
}
|
|
|
|
{
|
|
// Create a bound handle.
|
|
const handle = _createSocketHandle(common.localhostIPv4, 0, 'udp4');
|
|
|
|
assert(handle instanceof UDP);
|
|
assert.strictEqual(typeof handle.fd, 'number');
|
|
|
|
if (!common.isWindows)
|
|
assert(handle.fd > 0);
|
|
}
|
|
|
|
{
|
|
// Return an error if binding fails.
|
|
const err = _createSocketHandle('localhost', 0, 'udp4');
|
|
|
|
assert.strictEqual(typeof err, 'number');
|
|
assert(err < 0);
|
|
}
|