mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 03:31:35 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
// Tests below are not from WPT.
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const URLSearchParams = require('url').URLSearchParams;
|
|
|
|
{
|
|
const params = new URLSearchParams();
|
|
assert.throws(() => {
|
|
params.append.call(undefined);
|
|
}, {
|
|
code: 'ERR_INVALID_THIS',
|
|
name: 'TypeError',
|
|
message: 'Value of "this" must be of type URLSearchParams'
|
|
});
|
|
assert.throws(() => {
|
|
params.append('a');
|
|
}, {
|
|
code: 'ERR_MISSING_ARGS',
|
|
name: 'TypeError',
|
|
message: 'The "name" and "value" arguments must be specified'
|
|
});
|
|
|
|
const obj = {
|
|
toString() { throw new Error('toString'); },
|
|
valueOf() { throw new Error('valueOf'); }
|
|
};
|
|
const sym = Symbol();
|
|
assert.throws(() => params.set(obj, 'b'), /^Error: toString$/);
|
|
assert.throws(() => params.set('a', obj), /^Error: toString$/);
|
|
assert.throws(() => params.set(sym, 'b'),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
assert.throws(() => params.set('a', sym),
|
|
/^TypeError: Cannot convert a Symbol value to a string$/);
|
|
}
|