mirror of
https://github.com/nodejs/node.git
synced 2025-05-04 23:42:17 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
57 lines
1.2 KiB
JavaScript
57 lines
1.2 KiB
JavaScript
'use strict';
|
|
|
|
// From: https://github.com/w3c/web-platform-tests/blob/39a67e2fff/encoding/textdecoder-utf16-surrogates.html
|
|
// With the twist that we specifically test for Node.js error codes
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasIntl)
|
|
common.skip('missing Intl');
|
|
|
|
const assert = require('assert');
|
|
|
|
const bad = [
|
|
{
|
|
encoding: 'utf-16le',
|
|
input: [0x00, 0xd8],
|
|
expected: '\uFFFD',
|
|
name: 'lone surrogate lead'
|
|
},
|
|
{
|
|
encoding: 'utf-16le',
|
|
input: [0x00, 0xdc],
|
|
expected: '\uFFFD',
|
|
name: 'lone surrogate trail'
|
|
},
|
|
{
|
|
encoding: 'utf-16le',
|
|
input: [0x00, 0xd8, 0x00, 0x00],
|
|
expected: '\uFFFD\u0000',
|
|
name: 'unmatched surrogate lead'
|
|
},
|
|
{
|
|
encoding: 'utf-16le',
|
|
input: [0x00, 0xdc, 0x00, 0x00],
|
|
expected: '\uFFFD\u0000',
|
|
name: 'unmatched surrogate trail'
|
|
},
|
|
{
|
|
encoding: 'utf-16le',
|
|
input: [0x00, 0xdc, 0x00, 0xd8],
|
|
expected: '\uFFFD\uFFFD',
|
|
name: 'swapped surrogate pair'
|
|
}
|
|
];
|
|
|
|
bad.forEach((t) => {
|
|
assert.throws(
|
|
() => {
|
|
new TextDecoder(t.encoding, { fatal: true })
|
|
.decode(new Uint8Array(t.input));
|
|
}, {
|
|
code: 'ERR_ENCODING_INVALID_ENCODED_DATA',
|
|
name: 'TypeError'
|
|
}
|
|
);
|
|
});
|