mirror of
https://github.com/nodejs/node.git
synced 2025-05-10 06:41:09 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
62 lines
1.6 KiB
JavaScript
62 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
// From: https://github.com/w3c/web-platform-tests/blob/d74324b53c/encoding/textdecoder-fatal-streaming.html
|
|
// With the twist that we specifically test for Node.js error codes
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
if (!common.hasIntl)
|
|
common.skip('missing Intl');
|
|
|
|
{
|
|
[
|
|
{ encoding: 'utf-8', sequence: [0xC0] },
|
|
{ encoding: 'utf-16le', sequence: [0x00] },
|
|
{ encoding: 'utf-16be', sequence: [0x00] }
|
|
].forEach((testCase) => {
|
|
const data = new Uint8Array([testCase.sequence]);
|
|
assert.throws(
|
|
() => {
|
|
const decoder = new TextDecoder(testCase.encoding, { fatal: true });
|
|
decoder.decode(data);
|
|
}, {
|
|
code: 'ERR_ENCODING_INVALID_ENCODED_DATA',
|
|
name: 'TypeError',
|
|
message:
|
|
`The encoded data was not valid for encoding ${testCase.encoding}`
|
|
}
|
|
);
|
|
});
|
|
}
|
|
|
|
{
|
|
const decoder = new TextDecoder('utf-16le', { fatal: true });
|
|
const odd = new Uint8Array([0x00]);
|
|
const even = new Uint8Array([0x00, 0x00]);
|
|
|
|
assert.throws(
|
|
() => {
|
|
decoder.decode(even, { stream: true });
|
|
decoder.decode(odd);
|
|
}, {
|
|
code: 'ERR_ENCODING_INVALID_ENCODED_DATA',
|
|
name: 'TypeError',
|
|
message:
|
|
'The encoded data was not valid for encoding utf-16le'
|
|
}
|
|
);
|
|
|
|
assert.throws(
|
|
() => {
|
|
decoder.decode(odd, { stream: true });
|
|
decoder.decode(even);
|
|
}, {
|
|
code: 'ERR_ENCODING_INVALID_ENCODED_DATA',
|
|
name: 'TypeError',
|
|
message:
|
|
'The encoded data was not valid for encoding utf-16le'
|
|
}
|
|
);
|
|
}
|