mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 01:35:51 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
40 lines
765 B
JavaScript
40 lines
765 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
const { strictEqual } = require('assert');
|
|
const { Writable } = require('stream');
|
|
|
|
const w = new Writable();
|
|
|
|
w.on('error', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_METHOD_NOT_IMPLEMENTED',
|
|
message: 'The _write() method is not implemented'
|
|
}));
|
|
|
|
const bufferBlerg = Buffer.from('blerg');
|
|
|
|
w.end(bufferBlerg);
|
|
|
|
const _write = common.mustCall((chunk, _, next) => {
|
|
next();
|
|
});
|
|
|
|
const _writev = common.mustCall((chunks, next) => {
|
|
strictEqual(chunks.length, 2);
|
|
next();
|
|
});
|
|
|
|
const w2 = new Writable({ write: _write, writev: _writev });
|
|
|
|
strictEqual(w2._write, _write);
|
|
strictEqual(w2._writev, _writev);
|
|
|
|
w2.write(bufferBlerg);
|
|
|
|
w2.cork();
|
|
w2.write(bufferBlerg);
|
|
w2.write(bufferBlerg);
|
|
|
|
w2.end();
|