mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 13:11:36 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
23 lines
544 B
JavaScript
23 lines
544 B
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
require('../common');
|
|
const { strictEqual, throws } = require('assert');
|
|
const { NghttpError } = require('internal/http2/util');
|
|
|
|
throws(() => {
|
|
const err = new NghttpError(-501);
|
|
strictEqual(err.errno, -501);
|
|
throw err;
|
|
}, {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
constructor: NghttpError,
|
|
message: 'Invalid argument'
|
|
});
|
|
|
|
// Should convert the NghttpError object to string properly
|
|
{
|
|
const err = new NghttpError(401);
|
|
strictEqual(err.toString(), 'Error [ERR_HTTP2_ERROR]: Unknown error code');
|
|
}
|