mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 19:38:23 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
46 lines
911 B
JavaScript
46 lines
911 B
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const {
|
|
assertIsObject,
|
|
assertWithinRange,
|
|
} = require('internal/http2/util');
|
|
|
|
[
|
|
undefined,
|
|
{},
|
|
Object.create(null),
|
|
new Date(),
|
|
new (class Foo {})()
|
|
].forEach((input) => {
|
|
assertIsObject(input, 'foo', 'Object');
|
|
});
|
|
|
|
[
|
|
1,
|
|
false,
|
|
'hello',
|
|
NaN,
|
|
Infinity,
|
|
[],
|
|
[{}]
|
|
].forEach((input) => {
|
|
assert.throws(
|
|
() => assertIsObject(input, 'foo', 'Object'),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "foo" argument must be of type object.' +
|
|
common.invalidArgTypeHelper(input)
|
|
});
|
|
});
|
|
|
|
assertWithinRange('foo', 1, 0, 2);
|
|
|
|
assert.throws(() => assertWithinRange('foo', 1, 2, 3),
|
|
{
|
|
code: 'ERR_HTTP2_INVALID_SETTING_VALUE',
|
|
message: 'Invalid value for setting "foo": 1'
|
|
});
|