mirror of
https://github.com/nodejs/node.git
synced 2025-05-09 07:27:32 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
56 lines
1.7 KiB
JavaScript
56 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
const server = h2.createServer();
|
|
|
|
server.on('stream', common.mustCall((stream) => {
|
|
assert(stream.session);
|
|
stream.session.destroy();
|
|
assert.strictEqual(stream.session, undefined);
|
|
|
|
// Test that stream.state getter returns an empty object
|
|
// when the stream session has been destroyed
|
|
assert.deepStrictEqual({}, stream.state);
|
|
|
|
// Test that ERR_HTTP2_INVALID_STREAM is thrown while calling
|
|
// stream operations after the stream session has been destroyed
|
|
const invalidStreamError = {
|
|
name: 'Error',
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
message: 'The stream has been destroyed'
|
|
};
|
|
assert.throws(() => stream.additionalHeaders(), invalidStreamError);
|
|
assert.throws(() => stream.priority(), invalidStreamError);
|
|
assert.throws(() => stream.respond(), invalidStreamError);
|
|
assert.throws(
|
|
() => stream.pushStream({}, common.mustNotCall()),
|
|
{
|
|
code: 'ERR_HTTP2_PUSH_DISABLED',
|
|
name: 'Error'
|
|
}
|
|
);
|
|
stream.on('error', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
message: 'write after end'
|
|
}));
|
|
assert.strictEqual(stream.write('data', common.expectsError({
|
|
name: 'Error',
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
message: 'write after end'
|
|
})), false);
|
|
}));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = h2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
req.resume();
|
|
req.on('end', common.mustCall());
|
|
req.on('close', common.mustCall(() => server.close(common.mustCall())));
|
|
}));
|