mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 09:52:26 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
52 lines
1.4 KiB
JavaScript
52 lines
1.4 KiB
JavaScript
// Flags: --expose-internals
|
|
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const { kSocket } = require('internal/http2/util');
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustNotCall());
|
|
|
|
let test = 0;
|
|
|
|
server.on('session', common.mustCall((session) => {
|
|
switch (++test) {
|
|
case 1:
|
|
server.on('error', common.mustNotCall());
|
|
session.on('error', common.expectsError({
|
|
name: 'Error',
|
|
message: 'test'
|
|
}));
|
|
session[kSocket].emit('error', new Error('test'));
|
|
break;
|
|
case 2:
|
|
// If the server does not have a socketError listener,
|
|
// error will be silent on the server but will close
|
|
// the session
|
|
session[kSocket].emit('error', new Error('test'));
|
|
break;
|
|
}
|
|
}, 2));
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const url = `http://localhost:${server.address().port}`;
|
|
http2.connect(url)
|
|
.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_SESSION_ERROR',
|
|
message: 'Session closed with error code 2',
|
|
}))
|
|
.on('close', () => {
|
|
server.removeAllListeners('error');
|
|
http2.connect(url)
|
|
.on('error', common.expectsError({
|
|
code: 'ERR_HTTP2_SESSION_ERROR',
|
|
message: 'Session closed with error code 2',
|
|
}))
|
|
.on('close', () => server.close());
|
|
});
|
|
}));
|