mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
60 lines
1.5 KiB
JavaScript
60 lines
1.5 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
if (common.isWindows)
|
|
common.skip('no mkfifo on Windows');
|
|
const child_process = require('child_process');
|
|
const path = require('path');
|
|
const fs = require('fs');
|
|
const http2 = require('http2');
|
|
const assert = require('assert');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
tmpdir.refresh();
|
|
|
|
const pipeName = path.join(tmpdir.path, 'pipe');
|
|
|
|
const mkfifo = child_process.spawnSync('mkfifo', [ pipeName ]);
|
|
if (mkfifo.error && mkfifo.error.code === 'ENOENT') {
|
|
common.skip('missing mkfifo');
|
|
}
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', (stream) => {
|
|
stream.respondWithFile(pipeName, {
|
|
'content-type': 'text/plain'
|
|
}, {
|
|
offset: 10,
|
|
onError(err) {
|
|
common.expectsError({
|
|
code: 'ERR_HTTP2_SEND_FILE_NOSEEK',
|
|
name: 'Error',
|
|
message: 'Offset or length can only be specified for regular files'
|
|
})(err);
|
|
|
|
stream.respond({ ':status': 404 });
|
|
stream.end();
|
|
},
|
|
statCheck: common.mustNotCall()
|
|
});
|
|
});
|
|
server.listen(0, () => {
|
|
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const req = client.request();
|
|
|
|
req.on('response', common.mustCall((headers) => {
|
|
assert.strictEqual(headers[':status'], 404);
|
|
}));
|
|
req.on('data', common.mustNotCall());
|
|
req.on('end', common.mustCall(() => {
|
|
client.close();
|
|
server.close();
|
|
}));
|
|
req.end();
|
|
});
|
|
|
|
fs.writeFile(pipeName, 'Hello, world!\n', common.mustCall());
|