mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 22:40:57 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
68 lines
2.5 KiB
JavaScript
68 lines
2.5 KiB
JavaScript
// Copyright Joyent, Inc. and other Node contributors.
|
|
//
|
|
// Permission is hereby granted, free of charge, to any person obtaining a
|
|
// copy of this software and associated documentation files (the
|
|
// "Software"), to deal in the Software without restriction, including
|
|
// without limitation the rights to use, copy, modify, merge, publish,
|
|
// distribute, sublicense, and/or sell copies of the Software, and to permit
|
|
// persons to whom the Software is furnished to do so, subject to the
|
|
// following conditions:
|
|
//
|
|
// The above copyright notice and this permission notice shall be included
|
|
// in all copies or substantial portions of the Software.
|
|
//
|
|
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
|
|
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
|
|
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
|
|
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
|
|
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
|
|
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
|
|
// USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
'use strict';
|
|
const common = require('../common');
|
|
const fs = require('fs');
|
|
|
|
// Test that fs.readFile fails correctly on a non-existent file.
|
|
|
|
// `fs.readFile('/')` does not fail on AIX and FreeBSD because you can open
|
|
// and read the directory there.
|
|
if (common.isAIX || common.isFreeBSD)
|
|
common.skip('platform not supported.');
|
|
|
|
const assert = require('assert');
|
|
const exec = require('child_process').exec;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
function test(env, cb) {
|
|
const filename = fixtures.path('test-fs-readfile-error.js');
|
|
const execPath = `"${process.execPath}" "${filename}"`;
|
|
const options = { env: Object.assign({}, process.env, env) };
|
|
exec(execPath, options, (err, stdout, stderr) => {
|
|
assert(err);
|
|
assert.strictEqual(stdout, '');
|
|
assert.notStrictEqual(stderr, '');
|
|
cb(String(stderr));
|
|
});
|
|
}
|
|
|
|
test({ NODE_DEBUG: '' }, common.mustCall((data) => {
|
|
assert(/EISDIR/.test(data));
|
|
assert(/test-fs-readfile-error/.test(data));
|
|
}));
|
|
|
|
test({ NODE_DEBUG: 'fs' }, common.mustCall((data) => {
|
|
assert(/EISDIR/.test(data));
|
|
assert(/test-fs-readfile-error/.test(data));
|
|
}));
|
|
|
|
assert.throws(
|
|
() => { fs.readFile(() => {}, common.mustNotCall()); },
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "path" argument must be of type string or an instance of ' +
|
|
'Buffer or URL. Received type function ([Function (anonymous)])',
|
|
name: 'TypeError'
|
|
}
|
|
);
|