mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
33 lines
948 B
JavaScript
33 lines
948 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
// Ensures that child_process.fork can accept string
|
|
// variant of stdio parameter in options object and
|
|
// throws a TypeError when given an unexpected string
|
|
|
|
const assert = require('assert');
|
|
const fork = require('child_process').fork;
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const childScript = fixtures.path('child-process-spawn-node');
|
|
const malFormedOpts = { stdio: '33' };
|
|
const payload = { hello: 'world' };
|
|
|
|
assert.throws(
|
|
() => fork(childScript, malFormedOpts),
|
|
{ code: 'ERR_INVALID_OPT_VALUE', name: 'TypeError' });
|
|
|
|
function test(stringVariant) {
|
|
const child = fork(childScript, { stdio: stringVariant });
|
|
|
|
child.on('message', common.mustCall((message) => {
|
|
assert.deepStrictEqual(message, { foo: 'bar' });
|
|
}));
|
|
|
|
child.send(payload);
|
|
|
|
child.on('exit', common.mustCall((code) => assert.strictEqual(code, 0)));
|
|
}
|
|
|
|
['pipe', 'inherit', 'ignore'].forEach(test);
|