mirror of
https://github.com/nodejs/node.git
synced 2025-05-07 04:41:47 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
39 lines
1.3 KiB
JavaScript
39 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const { SlowBuffer } = require('buffer');
|
|
|
|
const msg = {
|
|
code: 'ERR_INVALID_OPT_VALUE',
|
|
name: 'RangeError',
|
|
message: /^The value "[^"]*" is invalid for option "size"$/
|
|
};
|
|
|
|
// Test that negative Buffer length inputs throw errors.
|
|
|
|
assert.throws(() => Buffer(-Buffer.poolSize), msg);
|
|
assert.throws(() => Buffer(-100), msg);
|
|
assert.throws(() => Buffer(-1), msg);
|
|
assert.throws(() => Buffer(NaN), msg);
|
|
|
|
assert.throws(() => Buffer.alloc(-Buffer.poolSize), msg);
|
|
assert.throws(() => Buffer.alloc(-100), msg);
|
|
assert.throws(() => Buffer.alloc(-1), msg);
|
|
assert.throws(() => Buffer.alloc(NaN), msg);
|
|
|
|
assert.throws(() => Buffer.allocUnsafe(-Buffer.poolSize), msg);
|
|
assert.throws(() => Buffer.allocUnsafe(-100), msg);
|
|
assert.throws(() => Buffer.allocUnsafe(-1), msg);
|
|
assert.throws(() => Buffer.allocUnsafe(NaN), msg);
|
|
|
|
assert.throws(() => Buffer.allocUnsafeSlow(-Buffer.poolSize), msg);
|
|
assert.throws(() => Buffer.allocUnsafeSlow(-100), msg);
|
|
assert.throws(() => Buffer.allocUnsafeSlow(-1), msg);
|
|
assert.throws(() => Buffer.allocUnsafeSlow(NaN), msg);
|
|
|
|
assert.throws(() => SlowBuffer(-Buffer.poolSize), msg);
|
|
assert.throws(() => SlowBuffer(-100), msg);
|
|
assert.throws(() => SlowBuffer(-1), msg);
|
|
assert.throws(() => SlowBuffer(NaN), msg);
|