mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 15:41:06 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
54 lines
1.4 KiB
JavaScript
54 lines
1.4 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../../common');
|
|
const skipMessage = 'intensive toString tests due to memory confinements';
|
|
if (!common.enoughTestMem)
|
|
common.skip(skipMessage);
|
|
|
|
const binding = require(`./build/${common.buildType}/binding`);
|
|
const assert = require('assert');
|
|
|
|
// v8 fails silently if string length > v8::String::kMaxLength
|
|
// v8::String::kMaxLength defined in v8.h
|
|
const kStringMaxLength = require('buffer').constants.MAX_STRING_LENGTH;
|
|
|
|
let buf;
|
|
try {
|
|
buf = Buffer.allocUnsafe(kStringMaxLength + 1);
|
|
} catch (e) {
|
|
// If the exception is not due to memory confinement then rethrow it.
|
|
if (e.message !== 'Array buffer allocation failed') throw (e);
|
|
common.skip(skipMessage);
|
|
}
|
|
|
|
// Ensure we have enough memory available for future allocations to succeed.
|
|
if (!binding.ensureAllocation(2 * kStringMaxLength))
|
|
common.skip(skipMessage);
|
|
|
|
const stringLengthHex = kStringMaxLength.toString(16);
|
|
|
|
assert.throws(() => {
|
|
buf.toString();
|
|
}, (e) => {
|
|
if (e.message !== 'Array buffer allocation failed') {
|
|
common.expectsError({
|
|
message: `Cannot create a string longer than 0x${stringLengthHex} ` +
|
|
'characters',
|
|
code: 'ERR_STRING_TOO_LONG',
|
|
name: 'Error'
|
|
})(e);
|
|
return true;
|
|
} else {
|
|
return true;
|
|
}
|
|
});
|
|
|
|
assert.throws(() => {
|
|
buf.toString('utf8');
|
|
}, {
|
|
message: `Cannot create a string longer than 0x${stringLengthHex} ` +
|
|
'characters',
|
|
code: 'ERR_STRING_TOO_LONG',
|
|
name: 'Error'
|
|
});
|