mirror of
https://github.com/nodejs/node.git
synced 2025-05-21 06:53:52 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
73 lines
2.2 KiB
JavaScript
73 lines
2.2 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
common.skipIfInspectorDisabled();
|
|
common.skipIf32Bits();
|
|
const { NodeInstance } = require('../common/inspector-helper');
|
|
const assert = require('assert');
|
|
|
|
const script = `runTest();
|
|
function runTest() {
|
|
const p = Promise.resolve();
|
|
p.then(function break1() { // lineNumber 3
|
|
debugger;
|
|
});
|
|
p.then(function break2() { // lineNumber 6
|
|
debugger;
|
|
});
|
|
}
|
|
`;
|
|
|
|
async function runTests() {
|
|
const instance = new NodeInstance(undefined, script);
|
|
const session = await instance.connectInspectorSession();
|
|
await session.send([
|
|
{ 'method': 'Runtime.enable' },
|
|
{ 'method': 'Debugger.enable' },
|
|
{ 'method': 'Debugger.setAsyncCallStackDepth',
|
|
'params': { 'maxDepth': 10 } },
|
|
{ 'method': 'Debugger.setBlackboxPatterns',
|
|
'params': { 'patterns': [] } },
|
|
{ 'method': 'Runtime.runIfWaitingForDebugger' }
|
|
]);
|
|
|
|
await session.waitForBreakOnLine(0, '[eval]');
|
|
await session.send({ 'method': 'Debugger.resume' });
|
|
|
|
console.error('[test] Waiting for break1');
|
|
debuggerPausedAt(await session.waitForBreakOnLine(6, '[eval]'),
|
|
'break1', 'runTest:5');
|
|
|
|
await session.send({ 'method': 'Debugger.resume' });
|
|
|
|
console.error('[test] Waiting for break2');
|
|
debuggerPausedAt(await session.waitForBreakOnLine(9, '[eval]'),
|
|
'break2', 'runTest:8');
|
|
|
|
await session.runToCompletion();
|
|
assert.strictEqual(0, (await instance.expectShutdown()).exitCode);
|
|
}
|
|
|
|
function debuggerPausedAt(msg, functionName, previousTickLocation) {
|
|
assert(
|
|
!!msg.params.asyncStackTrace,
|
|
`${Object.keys(msg.params)} contains "asyncStackTrace" property`);
|
|
|
|
assert.strictEqual(msg.params.callFrames[0].functionName, functionName);
|
|
assert.strictEqual(msg.params.asyncStackTrace.description, 'Promise.then');
|
|
|
|
const frameLocations = msg.params.asyncStackTrace.callFrames.map(
|
|
(frame) => `${frame.functionName}:${frame.lineNumber}`);
|
|
assertArrayIncludes(frameLocations, previousTickLocation);
|
|
}
|
|
|
|
function assertArrayIncludes(actual, expected) {
|
|
const expectedString = JSON.stringify(expected);
|
|
const actualString = JSON.stringify(actual);
|
|
assert(
|
|
actual.includes(expected),
|
|
`Expected ${actualString} to contain ${expectedString}.`);
|
|
}
|
|
|
|
runTests();
|