mirror of
https://github.com/nodejs/node.git
synced 2025-05-05 08:53:12 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
36 lines
1.2 KiB
JavaScript
36 lines
1.2 KiB
JavaScript
// Check that abrupt termination when async call stack recording is enabled
|
|
// does not segfault the process.
|
|
'use strict';
|
|
const common = require('../common');
|
|
common.skipIfInspectorDisabled();
|
|
common.skipIf32Bits();
|
|
|
|
const { strictEqual } = require('assert');
|
|
const eyecatcher = 'nou, houdoe he?';
|
|
|
|
if (process.argv[2] === 'child') {
|
|
common.disableCrashOnUnhandledRejection();
|
|
const { Session } = require('inspector');
|
|
const { promisify } = require('util');
|
|
const { registerAsyncHook } = process.binding('inspector');
|
|
(async () => {
|
|
let enabled = 0;
|
|
registerAsyncHook(() => ++enabled, () => {});
|
|
const session = new Session();
|
|
session.connect();
|
|
session.post = promisify(session.post);
|
|
await session.post('Debugger.enable');
|
|
strictEqual(enabled, 0);
|
|
await session.post('Debugger.setAsyncCallStackDepth', { maxDepth: 42 });
|
|
strictEqual(enabled, 1);
|
|
throw new Error(eyecatcher);
|
|
})();
|
|
} else {
|
|
const { spawnSync } = require('child_process');
|
|
const options = { encoding: 'utf8' };
|
|
const proc = spawnSync(process.execPath, [__filename, 'child'], options);
|
|
strictEqual(proc.status, 0);
|
|
strictEqual(proc.signal, null);
|
|
strictEqual(proc.stderr.includes(eyecatcher), true);
|
|
}
|