mirror of
https://github.com/nodejs/node.git
synced 2025-05-08 16:55:46 +00:00

This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
44 lines
1.0 KiB
JavaScript
44 lines
1.0 KiB
JavaScript
'use strict';
|
|
|
|
// Flags: --experimental-vm-modules --harmony-import-meta
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const { Module } = require('vm');
|
|
|
|
async function testBasic() {
|
|
const m = new Module('import.meta;', {
|
|
initializeImportMeta: common.mustCall((meta, module) => {
|
|
assert.strictEqual(module, m);
|
|
meta.prop = 42;
|
|
})
|
|
});
|
|
await m.link(common.mustNotCall());
|
|
m.instantiate();
|
|
const { result } = await m.evaluate();
|
|
assert.strictEqual(typeof result, 'object');
|
|
assert.strictEqual(Object.getPrototypeOf(result), null);
|
|
assert.strictEqual(result.prop, 42);
|
|
assert.deepStrictEqual(Reflect.ownKeys(result), ['prop']);
|
|
}
|
|
|
|
async function testInvalid() {
|
|
for (const invalidValue of [
|
|
null, {}, 0, Symbol.iterator, [], 'string', false
|
|
]) {
|
|
common.expectsError(() => {
|
|
new Module('', {
|
|
initializeImportMeta: invalidValue
|
|
});
|
|
}, {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
type: TypeError
|
|
});
|
|
}
|
|
}
|
|
|
|
(async () => {
|
|
await testBasic();
|
|
await testInvalid();
|
|
})();
|