mirror of
https://github.com/nodejs/node.git
synced 2025-05-01 08:42:45 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
44 lines
1.3 KiB
JavaScript
44 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
// The following tests validate base functionality for the fs.promises
|
|
// FileHandle.chmod method.
|
|
|
|
const fs = require('fs');
|
|
const { open } = fs.promises;
|
|
const path = require('path');
|
|
const tmpdir = require('../common/tmpdir');
|
|
const assert = require('assert');
|
|
const tmpDir = tmpdir.path;
|
|
|
|
tmpdir.refresh();
|
|
|
|
async function validateFilePermission() {
|
|
const filePath = path.resolve(tmpDir, 'tmp-chmod.txt');
|
|
const fileHandle = await open(filePath, 'w+', 0o444);
|
|
// file created with r--r--r-- 444
|
|
const statsBeforeMod = fs.statSync(filePath);
|
|
assert.deepStrictEqual(statsBeforeMod.mode & 0o444, 0o444);
|
|
|
|
let expectedAccess;
|
|
const newPermissions = 0o765;
|
|
|
|
if (common.isWindows) {
|
|
// chmod in Windows will only toggle read only/write access. the
|
|
// fs.Stats.mode in Windows is computed using read/write
|
|
// bits (not exec). read only at best returns 444; r/w 666.
|
|
// refer: /deps/uv/src/win/fs.cfs;
|
|
expectedAccess = 0o664;
|
|
} else {
|
|
expectedAccess = newPermissions;
|
|
}
|
|
|
|
// change the permissions to rwxr--r-x
|
|
await fileHandle.chmod(newPermissions);
|
|
const statsAfterMod = fs.statSync(filePath);
|
|
assert.deepStrictEqual(statsAfterMod.mode & expectedAccess, expectedAccess);
|
|
}
|
|
|
|
validateFilePermission().then(common.mustCall());
|