mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
34 lines
1.0 KiB
JavaScript
34 lines
1.0 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const async_hooks = require('async_hooks');
|
|
|
|
if (!common.isMainThread)
|
|
common.skip('Worker bootstrapping works differently -> different async IDs');
|
|
|
|
const promiseAsyncIds = [];
|
|
|
|
async_hooks.createHook({
|
|
init: common.mustCallAtLeast((id, type, triggerId) => {
|
|
if (type === 'PROMISE') {
|
|
// Check that the last known Promise is triggering the creation of
|
|
// this one.
|
|
assert.strictEqual(promiseAsyncIds[promiseAsyncIds.length - 1] || 1,
|
|
triggerId);
|
|
promiseAsyncIds.push(id);
|
|
}
|
|
}, 3),
|
|
before: common.mustCall((id) => {
|
|
assert.strictEqual(id, promiseAsyncIds[1]);
|
|
}),
|
|
after: common.mustCall((id) => {
|
|
assert.strictEqual(id, promiseAsyncIds[1]);
|
|
})
|
|
}).enable();
|
|
|
|
Promise.resolve(42).then(common.mustCall(() => {
|
|
assert.strictEqual(async_hooks.executionAsyncId(), promiseAsyncIds[1]);
|
|
assert.strictEqual(async_hooks.triggerAsyncId(), promiseAsyncIds[0]);
|
|
Promise.resolve(10);
|
|
}));
|