mirror of
https://github.com/nodejs/node.git
synced 2025-05-06 07:40:16 +00:00
4e6dc00401
There has been occasional nits for spacing in object literals in PRs but
the project does not lint for it and it is not always handled
consistently in the existing code, even on adjacent lines of a file.
This change enables a linting rule requiring no space between the key
and the colon, and requiring at least one space (but allowing for more
so property values can be lined up if desired) between the colon and the
value. This appears to be the most common style used in the current code
base.
Example code the complies with lint rule:
myObj = { foo: 'bar' };
Examples that do not comply with the lint rule:
myObj = { foo : 'bar' };
myObj = { foo:'bar' };
PR-URL: https://github.com/nodejs/node/pull/6592
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
128 lines
3.0 KiB
JavaScript
128 lines
3.0 KiB
JavaScript
'use strict';
|
|
var common = require('../common');
|
|
var assert = require('assert');
|
|
var path = require('path');
|
|
var fs = require('fs');
|
|
|
|
var expectFilePath = common.isWindows ||
|
|
process.platform === 'linux' ||
|
|
process.platform === 'darwin';
|
|
|
|
var watchSeenOne = 0;
|
|
var watchSeenTwo = 0;
|
|
var watchSeenThree = 0;
|
|
|
|
var testDir = common.tmpDir;
|
|
|
|
var filenameOne = 'watch.txt';
|
|
var filepathOne = path.join(testDir, filenameOne);
|
|
|
|
var filenameTwo = 'hasOwnProperty';
|
|
var filepathTwo = filenameTwo;
|
|
var filepathTwoAbs = path.join(testDir, filenameTwo);
|
|
|
|
var filenameThree = 'newfile.txt';
|
|
var testsubdir = path.join(testDir, 'testsubdir');
|
|
var filepathThree = path.join(testsubdir, filenameThree);
|
|
|
|
|
|
process.on('exit', function() {
|
|
assert.ok(watchSeenOne > 0);
|
|
assert.ok(watchSeenTwo > 0);
|
|
assert.ok(watchSeenThree > 0);
|
|
});
|
|
|
|
common.refreshTmpDir();
|
|
|
|
fs.writeFileSync(filepathOne, 'hello');
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(filepathOne);
|
|
watcher.on('change', function(event, filename) {
|
|
assert.equal('change', event);
|
|
|
|
if (expectFilePath) {
|
|
assert.equal('watch.txt', filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenOne;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
fs.writeFileSync(filepathOne, 'world');
|
|
});
|
|
|
|
|
|
process.chdir(testDir);
|
|
|
|
fs.writeFileSync(filepathTwoAbs, 'howdy');
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(filepathTwo, function(event, filename) {
|
|
assert.equal('change', event);
|
|
|
|
if (expectFilePath) {
|
|
assert.equal('hasOwnProperty', filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenTwo;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
fs.writeFileSync(filepathTwoAbs, 'pardner');
|
|
});
|
|
|
|
fs.mkdirSync(testsubdir, 0o700);
|
|
|
|
assert.doesNotThrow(
|
|
function() {
|
|
var watcher = fs.watch(testsubdir, function(event, filename) {
|
|
var renameEv = common.isSunOS ? 'change' : 'rename';
|
|
assert.equal(renameEv, event);
|
|
if (expectFilePath) {
|
|
assert.equal('newfile.txt', filename);
|
|
} else {
|
|
assert.equal(null, filename);
|
|
}
|
|
watcher.close();
|
|
++watchSeenThree;
|
|
});
|
|
}
|
|
);
|
|
|
|
setImmediate(function() {
|
|
var fd = fs.openSync(filepathThree, 'w');
|
|
fs.closeSync(fd);
|
|
});
|
|
|
|
// https://github.com/joyent/node/issues/2293 - non-persistent watcher should
|
|
// not block the event loop
|
|
fs.watch(__filename, {persistent: false}, function() {
|
|
assert(0);
|
|
});
|
|
|
|
// whitebox test to ensure that wrapped FSEvent is safe
|
|
// https://github.com/joyent/node/issues/6690
|
|
var oldhandle;
|
|
assert.throws(function() {
|
|
var w = fs.watch(__filename, function(event, filename) { });
|
|
oldhandle = w._handle;
|
|
w._handle = { close: w._handle.close };
|
|
w.close();
|
|
}, TypeError);
|
|
oldhandle.close(); // clean up
|
|
|
|
assert.throws(function() {
|
|
var w = fs.watchFile(__filename, {persistent: false}, function() {});
|
|
oldhandle = w._handle;
|
|
w._handle = { stop: w._handle.stop };
|
|
w.stop();
|
|
}, TypeError);
|
|
oldhandle.stop(); // clean up
|